Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2437813002: [Offline pages] Dropping bburns from TODOs and histogram ownership (Closed)

Created:
4 years, 2 months ago by fgorski
Modified:
4 years, 2 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, asvitkine+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Dropping bburns from TODOs and histogram ownership Replacing bburns with fgorski everyhere (TODOs and histograms). BUG=645522 TBR=asvitkine@chromium.org R=dimich@chromium.org Committed: https://crrev.com/ad4d36cdf36c91116305989c9d65b13d44bcf982 Cr-Commit-Position: refs/heads/master@{#426273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/offline_pages/offline_page_metadata_store_sql.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
fgorski
PTAL
4 years, 2 months ago (2016-10-19 18:29:56 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 2 months ago (2016-10-19 18:59:25 UTC) #4
dewittj
lgtm
4 years, 2 months ago (2016-10-19 19:07:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437813002/1
4 years, 2 months ago (2016-10-19 20:14:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 20:39:32 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:11:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad4d36cdf36c91116305989c9d65b13d44bcf982
Cr-Commit-Position: refs/heads/master@{#426273}

Powered by Google App Engine
This is Rietveld 408576698