Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2437593005: Fix compilation of uber-fat binaries. (Closed)

Created:
4 years, 2 months ago by sdefresne
Modified:
4 years, 2 months ago
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compilation of uber-fat binaries. Fix compilation of fat binaries supporting both device and simulator by always defining the target to generate the embedded entitlement file in the default toolchain. Fix native_client_sdk/src/build_tools/build_sdk.py to not override use_ios_simulator (as this should not be a configurable variable) and make the variable non configurable. Note that uber-fat builds cannot be used as-is and require some processing to tweak the Info.plist file (CFBundleSupportedPlatforms and DTPlatformName reference the target platform). BUG=654827 Committed: https://crrev.com/4f7dea0a1f25b46d0d3d5159142f7560dae409ab Cr-Commit-Position: refs/heads/master@{#426285}

Patch Set 1 #

Patch Set 2 : Fix typo in native_client_sdk/PRESUBMIT.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/config/ios/ios_sdk.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M build/config/ios/rules.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/PRESUBMIT.py View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
sdefresne
Please take a look. justincohen: - build/config/ios/... bradnelson: - native_client_sdk/...
4 years, 2 months ago (2016-10-19 18:14:54 UTC) #5
Sam Clegg
native_client_sdk/ lgtm
4 years, 2 months ago (2016-10-19 18:38:06 UTC) #7
bradn
lgtm
4 years, 2 months ago (2016-10-19 18:49:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437593005/20001
4 years, 2 months ago (2016-10-19 18:49:59 UTC) #11
justincohen
lgtm
4 years, 2 months ago (2016-10-19 19:06:38 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 21:12:55 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:11:30 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f7dea0a1f25b46d0d3d5159142f7560dae409ab
Cr-Commit-Position: refs/heads/master@{#426285}

Powered by Google App Engine
This is Rietveld 408576698