native_client_sdk/src/build_tools/build_sdk.py - Issue 2437593005: Fix compilation of uber-fat binaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/build_sdk.py

Issue 2437593005: Fix compilation of uber-fat binaries. (Closed)

Patch Set: Fix typo in native_client_sdk/PRESUBMIT.py Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/build_tools/build_sdk.py

diff --git a/native_client_sdk/src/build_tools/build_sdk.py b/native_client_sdk/src/build_tools/build_sdk.py

index 945e8b260e14a391d0278fe0ed4ddca0a0152a48..93db6d54fcd4d2affdf45915952410fe82c92a34 100755

--- a/native_client_sdk/src/build_tools/build_sdk.py

+++ b/native_client_sdk/src/build_tools/build_sdk.py

@@ -433,7 +433,7 @@ def GnNinjaBuild(arch, out_dir, extra_gn_args=None):

if arch == 'arm':

# Without this the target_cpu='arm' build complains about missing code

# signing identity

- gn_args.append('use_ios_simulator=true')

+ gn_args.append('ios_enable_code_signing=false')

gn_exe = GetGNExecutable(platform)

« no previous file with comments | « native_client_sdk/PRESUBMIT.py ('k') | no next file » | no next file with comments »