Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 2437343002: Take one-shot focus for WebRTC on Android (Closed)

Created:
4 years, 2 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 2 months ago
CC:
braveyao, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Take one-shot focus for WebRTC on Android There is a conflict in two recent CLs: https://chromiumcodereview.appspot.com/2437963002 https://chromiumcodereview.appspot.com/2428353005, in which WebRTC does not take audio focus both for the input stream and the output stream. This CL lets WebRTC take audio focus on Android from MediaSession again to fix the issue. BUG=596516 Committed: https://crrev.com/2e14f672e9c90c414fb752ead4d355194cc00dc6 Cr-Commit-Position: refs/heads/master@{#426845}

Patch Set 1 #

Patch Set 2 : Take one-shot focus for WebRTC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Zhiqiang Zhang (Slow)
PTAL Sorry for the inconvenience.
4 years, 2 months ago (2016-10-21 10:17:48 UTC) #5
mlamouri (slow - plz ping)
lgtm
4 years, 2 months ago (2016-10-21 10:22:18 UTC) #7
DaleCurtis
lgtm
4 years, 2 months ago (2016-10-21 17:15:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437343002/20001
4 years, 2 months ago (2016-10-21 17:44:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 18:15:03 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 18:42:36 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e14f672e9c90c414fb752ead4d355194cc00dc6
Cr-Commit-Position: refs/heads/master@{#426845}

Powered by Google App Engine
This is Rietveld 408576698