Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 2437963002: AudioManagerAndroid: remove audio focus request and saved audio mode (Closed)

Created:
4 years, 2 months ago by braveyao
Modified:
4 years, 2 months ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mlamouri+watch-media_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioManagerAndroid: remove audio focus request and saved audio mode We used to request audio focus in AndioManagerAndroid and save/restore the audio mode. Both are not necessary now. The newly added MediaSessionDelegate will take care of audio focus. And it's more resonable to switch back to NORMAL since we can't know that the saved mode is still valid. This will be handled by Android audio frame. BUG=650533 Committed: https://crrev.com/03623e2394747cac121f6c7d4dc011e0418e2b64 Cr-Commit-Position: refs/heads/master@{#426519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -53 lines) Patch
M media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java View 7 chunks +5 lines, -53 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
braveyao
Hi qinmin, Please take a look at this!
4 years, 2 months ago (2016-10-20 17:01:40 UTC) #6
qinmin
lgtm
4 years, 2 months ago (2016-10-20 17:03:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437963002/1
4 years, 2 months ago (2016-10-20 17:04:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 17:23:47 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:19:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03623e2394747cac121f6c7d4dc011e0418e2b64
Cr-Commit-Position: refs/heads/master@{#426519}

Powered by Google App Engine
This is Rietveld 408576698