Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2437273002: fix multibuffer "is loading" (Closed)

Created:
4 years, 2 months ago by hubbe
Modified:
4 years, 2 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix multibuffer "is loading" The multibuffer tells the client that we are loading, even if the content is already cached. However, if the content is fully cached, there will be no progress updates, and the we'll never tell the client that we stopped loading. This CL fixes that by posting a task that checks the loading state right after startup. BUG=657922 Committed: https://crrev.com/6d357201a8fc298f606d9ddcae7f6192e2cb0758 Cr-Commit-Position: refs/heads/master@{#426886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M media/blink/multibuffer_data_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/multibuffer_data_source.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hubbe
4 years, 2 months ago (2016-10-21 00:30:36 UTC) #5
chcunningham
lgtm Thanks Hubbe!
4 years, 2 months ago (2016-10-21 20:31:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437273002/1
4 years, 2 months ago (2016-10-21 20:35:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 20:59:59 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 21:03:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d357201a8fc298f606d9ddcae7f6192e2cb0758
Cr-Commit-Position: refs/heads/master@{#426886}

Powered by Google App Engine
This is Rietveld 408576698