Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2437063002: re-re-land of skslc now automatically turns on derivatives support (Closed)

Created:
4 years, 2 months ago by ethannicholas
Modified:
4 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

re-re-land of skslc now automatically turns on derivatives support Only change from last attempt is putting the call to shaderDerivativeExtensionString behind a check for shaderDerivativeSupport to avoid a spurious assertion failure. TBR=benjaminwagner@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2437063002 Committed: https://skia.googlesource.com/skia/+/ddb37d67ba4db42fa5c6012b58d0f4985b454dc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -93 lines) Patch
M fuzz/fuzz.cpp View 1 chunk +1 line, -13 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 6 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/instanced/InstanceProcessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/sksl/SkSLCompiler.cpp View 3 chunks +4 lines, -1 line 0 comments Download
M src/sksl/SkSLGLSLCodeGenerator.h View 3 chunks +20 lines, -16 lines 0 comments Download
M src/sksl/SkSLGLSLCodeGenerator.cpp View 6 chunks +15 lines, -3 lines 0 comments Download
M src/sksl/SkSLMain.cpp View 2 chunks +1 line, -13 lines 0 comments Download
M src/sksl/ir/SkSLFunctionDeclaration.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/sksl/ir/SkSLSymbolTable.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/sksl/ir/SkSLSymbolTable.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M tests/SkSLGLSLTest.cpp View 2 chunks +28 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437063002/1
4 years, 2 months ago (2016-10-20 16:52:47 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 16:54:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ddb37d67ba4db42fa5c6012b58d0f4985b454dc0

Powered by Google App Engine
This is Rietveld 408576698