Upgrade libsrtp to version 2.0 (second attempt)

Upgrade libsrtp to version 2.0

Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.

Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits).

https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63..71692eaab2a0

$ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s'
2016-10-20 kjellander Only build libsrtp tests if a build flag is set
2016-10-20 kjellander Don't build tests on Windows.
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0

BUG=webrtc:6376
Committed: https://crrev.com/c2eb0266eee3348b00ad3cdc1261d71cefe47333
Cr-Commit-Position: refs/heads/master@{#426814}

[mattdr-at-chromium, 2016-10-20 08:36:04]

The CQ bit was checked by mattdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 08:36:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 10:01:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 10:01:42]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[mattdr-at-chromium, 2016-10-20 17:01:01]

Description was changed from

==========
Upgrade libsrtp to version 2.0

Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.

https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63...

$ git log b17c065a8..8d698471f --date=short --no-merges --format='%ad %ae %s'
2016-10-20 kjellander Don't build tests on Windows.
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0

BUG=webrtc:6376
==========

to

==========
Upgrade libsrtp to version 2.0

Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.

Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits).

https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63...

$ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s'
2016-10-20 kjellander Only build libsrtp tests if a build flag is set
2016-10-20 kjellander Don't build tests on Windows.
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0

BUG=webrtc:6376
==========

[mattdr-at-chromium, 2016-10-20 17:02:14]

The CQ bit was checked by mattdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 17:02:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 20:29:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 20:29:03]

Dry run: This issue passed the CQ dry run.

[mattdr-at-chromium, 2016-10-20 20:32:37]

mattdr@chromium.org changed reviewers:
+ jochen@chromium.org, kjellander@chromium.org, mmoroz@chromium.org

[mattdr-at-chromium, 2016-10-20 20:32:38]

This is a second attempt to land https://codereview.chromium.org/2398073002,
which was rolled back as described in
https://bugs.chromium.org/p/webrtc/issues/detail?id=6376#c6.

This CL removes *all* references to libsrtp tests from src/BUILD.gn because they
will not build by default. The changes to libsrtp_fuzzer.cc are identical to
before.

[kjellander_chromium, 2016-10-20 20:39:03]

lgtm

[mmoroz, 2016-10-21 09:40:41]

LGTM for fuzzer. Thanks for the update!

https://codereview.chromium.org/2436913003/diff/40001/testing/libfuzzer/fuzze...
File testing/libfuzzer/fuzzers/libsrtp_fuzzer.cc (right):

https://codereview.chromium.org/2436913003/diff/40001/testing/libfuzzer/fuzze...
testing/libfuzzer/fuzzers/libsrtp_fuzzer.cc:6: #include <netinet/in.h>
Is it needed?

[jochen (gone - plz use gerrit), 2016-10-21 11:05:17]

lgtm

[mattdr-at-chromium, 2016-10-21 16:25:48]

https://codereview.chromium.org/2436913003/diff/40001/testing/libfuzzer/fuzze...
File testing/libfuzzer/fuzzers/libsrtp_fuzzer.cc (right):

https://codereview.chromium.org/2436913003/diff/40001/testing/libfuzzer/fuzze...
testing/libfuzzer/fuzzers/libsrtp_fuzzer.cc:6: #include <netinet/in.h>
On 2016/10/21 09:40:41, mmoroz wrote:
> Is it needed?

Hm. No, it doesn't seem like this is needed and I can't explain why I added it.

Rather than further complicate this review, I hope you'll forgive me for
checking this in and sending a followon CL to remove this.

[mattdr-at-chromium, 2016-10-21 16:27:09]

Adding webrtc-perf-sheriffs@ since this may have performance impact -- likely
and hopefully positive!

[mattdr-at-chromium, 2016-10-21 16:27:18]

The CQ bit was checked by mattdr@chromium.org

[commit-bot: I haz the power, 2016-10-21 16:27:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 16:47:49]

Description was changed from

==========
Upgrade libsrtp to version 2.0

Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.

Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits).

https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63...

$ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s'
2016-10-20 kjellander Only build libsrtp tests if a build flag is set
2016-10-20 kjellander Don't build tests on Windows.
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0

BUG=webrtc:6376
==========

to

==========
Upgrade libsrtp to version 2.0

Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.

Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits).

https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63...

$ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s'
2016-10-20 kjellander Only build libsrtp tests if a build flag is set
2016-10-20 kjellander Don't build tests on Windows.
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0

BUG=webrtc:6376
==========

[commit-bot: I haz the power, 2016-10-21 16:47:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 17:05:48]

Description was changed from

==========
Upgrade libsrtp to version 2.0

Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.

Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits).

https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63...

$ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s'
2016-10-20 kjellander Only build libsrtp tests if a build flag is set
2016-10-20 kjellander Don't build tests on Windows.
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0

BUG=webrtc:6376
==========

to

==========
Upgrade libsrtp to version 2.0

Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.

Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits).

https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63...

$ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s'
2016-10-20 kjellander Only build libsrtp tests if a build flag is set
2016-10-20 kjellander Don't build tests on Windows.
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0

BUG=webrtc:6376

Committed: https://crrev.com/c2eb0266eee3348b00ad3cdc1261d71cefe47333
Cr-Commit-Position: refs/heads/master@{#426814}
==========

[commit-bot: I haz the power, 2016-10-21 17:05:49]

Patchset 3 (id:??) landed as
https://crrev.com/c2eb0266eee3348b00ad3cdc1261d71cefe47333
Cr-Commit-Position: refs/heads/master@{#426814}