reland: Reusing Ok/Cancel buttons for intent picker

reland: Reusing Ok/Cancel buttons for intent picker

The revert was documented in here http://crbug.com/657240, it is likely
that ASAN builders messed up due to a dummy event used as input for the
intent picker, this only affects the unit tests.

The original CL can be found here:
https://codereview.chromium.org/2229943003/

BUG=620129, 638063
TEST=Manual test, also IntentPickerBubbleViewTest unit tests passing.

Committed: https://crrev.com/44b2b5b87c4e60df510b42f3be6dc17d83526d31
Cr-Commit-Position: refs/heads/master@{#426530}

[djacobo_, 2016-10-19 21:02:23]

The CQ bit was checked by djacobo@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 21:03:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 22:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:21:21]

Dry run: This issue passed the CQ dry run.

[djacobo_, 2016-10-19 23:47:37]

The CQ bit was checked by djacobo@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 23:48:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 03:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 03:35:35]

Dry run: This issue passed the CQ dry run.

[djacobo_, 2016-10-20 06:18:21]

The CQ bit was checked by djacobo@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 06:18:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 06:31:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 06:31:01]

Dry run: This issue passed the CQ dry run.

[djacobo_, 2016-10-20 08:06:32]

Description was changed from

==========
reland: Reusing Ok/Cancel buttons for intent picker

The revert was documented in here http://crbug.com/657240, it is likely
that ASAN builders messed up due to a dummy event used as input for the
intent picker, this only affects the unit tests.

The original CL can be found here:
https://codereview.chromium.org/2229943003/

BUG=620129, 638063
TEST=Manual test, also IntentPickerBubbleViewTest unit tests passing.
==========

to

==========
reland: Reusing Ok/Cancel buttons for intent picker

The revert was documented in here http://crbug.com/657240, it is likely
that ASAN builders messed up due to a dummy event used as input for the
intent picker, this only affects the unit tests.

The original CL can be found here:
https://codereview.chromium.org/2229943003/

BUG=620129, 638063
TEST=Manual test, also IntentPickerBubbleViewTest unit tests passing.
==========

[djacobo_, 2016-10-20 08:06:32]

djacobo@google.com changed reviewers:
+ elijahtaylor@chromium.org, sky@chromium.org, yusukes@chromium.org

[djacobo_, 2016-10-20 08:08:56]

As stated in the CL description, had some problems with the address sanitizer
trybot due to the way I simulated input events for testing. You can see the
original reverted code in the patchset 1, changes are minimal.

[sky, 2016-10-20 16:00:52]

LGTM

[Yusuke Sato, 2016-10-20 17:58:09]

lgtm

[djacobo_, 2016-10-20 18:00:09]

The CQ bit was checked by djacobo@google.com

[commit-bot: I haz the power, 2016-10-20 18:00:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:10:06]

Description was changed from

==========
reland: Reusing Ok/Cancel buttons for intent picker

The revert was documented in here http://crbug.com/657240, it is likely
that ASAN builders messed up due to a dummy event used as input for the
intent picker, this only affects the unit tests.

The original CL can be found here:
https://codereview.chromium.org/2229943003/

BUG=620129, 638063
TEST=Manual test, also IntentPickerBubbleViewTest unit tests passing.
==========

to

==========
reland: Reusing Ok/Cancel buttons for intent picker

The revert was documented in here http://crbug.com/657240, it is likely
that ASAN builders messed up due to a dummy event used as input for the
intent picker, this only affects the unit tests.

The original CL can be found here:
https://codereview.chromium.org/2229943003/

BUG=620129, 638063
TEST=Manual test, also IntentPickerBubbleViewTest unit tests passing.
==========

[commit-bot: I haz the power, 2016-10-20 18:10:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:20:12]

Description was changed from

==========
reland: Reusing Ok/Cancel buttons for intent picker

The revert was documented in here http://crbug.com/657240, it is likely
that ASAN builders messed up due to a dummy event used as input for the
intent picker, this only affects the unit tests.

The original CL can be found here:
https://codereview.chromium.org/2229943003/

BUG=620129, 638063
TEST=Manual test, also IntentPickerBubbleViewTest unit tests passing.
==========

to

==========
reland: Reusing Ok/Cancel buttons for intent picker

The revert was documented in here http://crbug.com/657240, it is likely
that ASAN builders messed up due to a dummy event used as input for the
intent picker, this only affects the unit tests.

The original CL can be found here:
https://codereview.chromium.org/2229943003/

BUG=620129, 638063
TEST=Manual test, also IntentPickerBubbleViewTest unit tests passing.

Committed: https://crrev.com/44b2b5b87c4e60df510b42f3be6dc17d83526d31
Cr-Commit-Position: refs/heads/master@{#426530}
==========

[commit-bot: I haz the power, 2016-10-21 13:20:13]

Patchset 2 (id:??) landed as
https://crrev.com/44b2b5b87c4e60df510b42f3be6dc17d83526d31
Cr-Commit-Position: refs/heads/master@{#426530}