Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2211)

Unified Diff: chrome/browser/ui/browser_dialogs.h

Issue 2436543003: reland: Reusing Ok/Cancel buttons for intent picker (Closed)
Patch Set: Modifying the way I create a dummy event for the testing. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_dialogs.h
diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h
index ee266a5ad821ba5f79efcb2b479a5ed0cae0b555..0bc1b7e8700030e286936e264bc378e7b8a21eee 100644
--- a/chrome/browser/ui/browser_dialogs.h
+++ b/chrome/browser/ui/browser_dialogs.h
@@ -174,12 +174,19 @@ class ContentSettingBubbleViewsBridge {
#if defined(OS_CHROMEOS)
+// This callback informs the package name of the app selected by the user, along
+// with the reason why the Bubble was closed. The string param must have a valid
+// package name, except when the CloseReason is ERROR or DIALOG_DEACTIVATED, for
+// these cases we return a dummy value which won't be used at all and has no
+// significance.
+using IntentPickerResponse =
+ base::Callback<void(std::string, arc::ArcNavigationThrottle::CloseReason)>;
+
// Return a pointer to the IntentPickerBubbleView::ShowBubble method.
-using BubbleShowPtr = void (*)(
- content::WebContents*,
- const std::vector<std::pair<std::basic_string<char>, gfx::Image>>&,
- const base::Callback<void(size_t,
- arc::ArcNavigationThrottle::CloseReason)>&);
+using BubbleShowPtr =
+ void (*)(content::WebContents*,
+ const std::vector<arc::ArcNavigationThrottle::AppInfo>&,
+ const IntentPickerResponse&);
BubbleShowPtr ShowIntentPickerBubble();
« no previous file with comments | « chrome/browser/chromeos/arc/arc_navigation_throttle.cc ('k') | chrome/browser/ui/views/intent_picker_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698