Remove supervised users from the app list profile selector.

Remove supervised users from the app list profile selector.

This CL filters out managed users from the app list profile selector.

Users can still try to switch to the managed user from the app launcher
settings. This will result in a no op.

BUG=293522
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224984

[tapted, 2013-09-24 04:47:37]

lgtm

[commit-bot: I haz the power, 2013-09-24 09:35:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/24360013/6001

[commit-bot: I haz the power, 2013-09-24 12:43:53]

Change committed as 224984

[koz (OOO until 15th September), 2013-09-25 23:35:58]

https://chromiumcodereview.appspot.com/24360013/diff/6001/chrome/browser/ui/a...
File chrome/browser/ui/app_list/app_list_service_impl.cc (right):

https://chromiumcodereview.appspot.com/24360013/diff/6001/chrome/browser/ui/a...
chrome/browser/ui/app_list/app_list_service_impl.cc:151: // Ensure we don't set
the pref to a managed user's profile path.
Is this ever expected to be hit? If not it should be removed. We don't do other
consistency checks like ensuring that the path exists as it's the caller's
responsibility to ensure such things.

[tapted, 2013-09-26 03:52:50]

https://chromiumcodereview.appspot.com/24360013/diff/6001/chrome/browser/ui/a...
File chrome/browser/ui/app_list/app_list_service_impl.cc (right):

https://chromiumcodereview.appspot.com/24360013/diff/6001/chrome/browser/ui/a...
chrome/browser/ui/app_list/app_list_service_impl.cc:151: // Ensure we don't set
the pref to a managed user's profile path.
On 2013/09/25 23:35:58, koz wrote:
> Is this ever expected to be hit? If not it should be removed. We don't do
other
> consistency checks like ensuring that the path exists as it's the caller's
> responsibility to ensure such things.

Calamity can confirm, but I'm pretty sure this is the path the Settings App goes
through using the button there. There's no filtering for supervised users in
that list, so if someone switches to a supervised user with the settings app, it
will get permanently wedged in a state where it can't show the app list (or
settings again), because of the check in AppListController::ShowForProfile.

This is a slight improvement, although not the best. But the Apps story for
supervised users is broken in a few ways at the moment.

[koz (OOO until 15th September), 2013-09-26 05:29:07]

On 2013/09/26 03:52:50, tapted wrote:
>
https://chromiumcodereview.appspot.com/24360013/diff/6001/chrome/browser/ui/a...
> File chrome/browser/ui/app_list/app_list_service_impl.cc (right):
> 
>
https://chromiumcodereview.appspot.com/24360013/diff/6001/chrome/browser/ui/a...
> chrome/browser/ui/app_list/app_list_service_impl.cc:151: // Ensure we don't
set
> the pref to a managed user's profile path.
> On 2013/09/25 23:35:58, koz wrote:
> > Is this ever expected to be hit? If not it should be removed. We don't do
> other
> > consistency checks like ensuring that the path exists as it's the caller's
> > responsibility to ensure such things.
> 
> Calamity can confirm, but I'm pretty sure this is the path the Settings App
goes
> through using the button there. There's no filtering for supervised users in
> that list, so if someone switches to a supervised user with the settings app,
it
> will get permanently wedged in a state where it can't show the app list (or
> settings again), because of the check in AppListController::ShowForProfile.
> 
> This is a slight improvement, although not the best. But the Apps story for
> supervised users is broken in a few ways at the moment.

Ah, that is unfortunate. Ok, thanks for the info! I'll add a TODO for fixing it.
(Oh, I also see that this was mentioned in the change description. Sorry for the
noise!)