Remove supervised users from the app list profile selector.

chrome/browser/ui/app_list/app_list_service_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/app_list_service_impl.h"
 
 #include "apps/pref_names.h"
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
@@ skipping 130 matching lines @@
   }
 
   // If there is no last used profile recorded, use the initial profile.
   if (app_list_profile.empty())
     app_list_profile = chrome::kInitialProfile;
 
   return user_data_dir.AppendASCII(app_list_profile);
 }
 
 void AppListServiceImpl::SetProfilePath(const base::FilePath& profile_path) {
+  // Ensure we don't set the pref to a managed user's profile path.

[koz (OOO until 15th September), 2013/09/25 23:35:58]

Is this ever expected to be hit? If not it should be removed. We don't do other
consistency checks like ensuring that the path exists as it's the caller's
responsibility to ensure such things.

[tapted, 2013/09/26 03:52:50]

Calamity can confirm, but I'm pretty sure this is the path the Settings App goes
through using the button there. There's no filtering for supervised users in
that list, so if someone switches to a supervised user with the settings app, it
will get permanently wedged in a state where it can't show the app list (or
settings again), because of the check in AppListController::ShowForProfile.

This is a slight improvement, although not the best. But the Apps story for
supervised users is broken in a few ways at the moment.

+  ProfileInfoCache& profile_info =
+      g_browser_process->profile_manager()->GetProfileInfoCache();
+  size_t profile_index = profile_info.GetIndexOfProfileWithPath(profile_path);
+  if (profile_info.ProfileIsManagedAtIndex(profile_index))
+    return;
+
   g_browser_process->local_state()->SetString(
       prefs::kAppListProfile,
       profile_path.BaseName().MaybeAsASCII());
 }
 
 void AppListServiceImpl::CreateShortcut() {}
 
 // We need to watch for profile removal to keep kAppListProfile updated.
 void AppListServiceImpl::OnProfileWillBeRemoved(
     const base::FilePath& profile_path) {
@@ skipping 43 matching lines @@
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableAppList))
     SetAppListEnabledPreference(false);
 
   // Send app list usage stats after a delay.
   const int kSendUsageStatsDelay = 5;
   base::MessageLoop::current()->PostDelayedTask(
       FROM_HERE,
       base::Bind(&AppListServiceImpl::SendAppListStats),
       base::TimeDelta::FromSeconds(kSendUsageStatsDelay));
 }