Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2435973003: [Bindings][Refactoring] Make binding scripts use utilities to handle pickle files (Closed)

Created:
4 years, 2 months ago by peria
Modified:
4 years, 2 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make binding scripts use utilities to handle pickle files As a side effect, this CL adds read_pickle_file() beside read_picke_files() in utilities.py. BUG=650150 Committed: https://crrev.com/b7ff4b88ad3751f8b8ac32a50c9c063c0f672617 Cr-Commit-Position: refs/heads/master@{#426744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py View 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py View 2 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/idl_compiler.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/utilities.py View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
peria
PTL
4 years, 2 months ago (2016-10-21 05:22:14 UTC) #4
bashi
lgtm We might want to have a bug entry for this kind of refactoring CLs.
4 years, 2 months ago (2016-10-21 05:30:44 UTC) #5
peria
On 2016/10/21 05:30:44, bashi1 wrote: > lgtm > > We might want to have a ...
4 years, 2 months ago (2016-10-21 05:33:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435973003/1
4 years, 2 months ago (2016-10-21 05:33:39 UTC) #9
haraken
LGTM
4 years, 2 months ago (2016-10-21 06:46:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 07:14:48 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:27:58 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7ff4b88ad3751f8b8ac32a50c9c063c0f672617
Cr-Commit-Position: refs/heads/master@{#426744}

Powered by Google App Engine
This is Rietveld 408576698