[Bindings][Refactoring] Make binding scripts use utilities to handle pickle files

third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py

 #!/usr/bin/python
 #
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates interface properties on global objects.
 
 Concretely these are implemented as "constructor attributes", meaning
 "attributes whose name ends with Constructor" (special-cased by code generator),
 hence "global constructors" for short.
 
 For reference on global objects, see:
 http://heycam.github.io/webidl/#Global
 http://heycam.github.io/webidl/#Exposed
 
 Design document: http://www.chromium.org/developers/design-documents/idl-build
 """
 
+# pylint: disable=relative-import
+
 import itertools
 import optparse
 import os
-import cPickle as pickle
 import re
 import sys
 
+from collections import defaultdict
+from utilities import get_file_contents
+from utilities import get_interface_exposed_arguments
+from utilities import get_interface_extended_attributes_from_idl
+from utilities import idl_filename_to_interface_name
+from utilities import is_callback_interface_from_idl
+from utilities import read_file_to_list
+from utilities import read_pickle_file
+from utilities import should_generate_impl_file_from_idl
+from utilities import write_file
 from v8_utilities import EXPOSED_EXECUTION_CONTEXT_METHOD
 
-from collections import defaultdict
-from utilities import should_generate_impl_file_from_idl, get_file_contents, idl_filename_to_interface_name, read_file_to_list, write_file, get_interface_extended_attributes_from_idl, get_interface_exposed_arguments, is_callback_interface_from_idl
-
 interface_name_to_global_names = {}
 global_name_to_constructors = defaultdict(list)
 
 
 HEADER_FORMAT = """// Stub header file for {{idl_basename}}
 // Required because the IDL compiler assumes that a corresponding header file
 // exists for each IDL file.
 """
 
 def parse_options():
@@ skipping 106 matching lines @@
     # limits. This is generated at GYP time, which is ok b/c files are static.
     idl_files = read_file_to_list(options.idl_files_list)
 
     # Output IDL files (to generate) are passed at the command line, since
     # these are in the build directory, which is determined at build time, not
     # GYP time.
     # These are passed as pairs of GlobalObjectName, GlobalObject.idl
     interface_name_idl_filename = [(args[i], args[i + 1])
                                    for i in range(0, len(args), 2)]
 
-    with open(options.global_objects_file) as global_objects_file:
-        interface_name_to_global_names.update(pickle.load(global_objects_file))
+    interface_name_to_global_names.update(read_pickle_file(options.global_objects_file))
 
     for idl_filename in idl_files:
         record_global_constructors(idl_filename)
 
     # Check for [Exposed] / [Global] mismatch.
     known_global_names = EXPOSED_EXECUTION_CONTEXT_METHOD.keys()
     exposed_global_names = frozenset(global_name_to_constructors)
     if not exposed_global_names.issubset(known_global_names):
         unknown_global_names = exposed_global_names.difference(known_global_names)
         raise ValueError('The following global names were used in '
                          '[Exposed=xxx] but do not match any [Global] / '
                          '[PrimaryGlobal] interface: %s'
                          % list(unknown_global_names))
 
     # Write partial interfaces containing constructor attributes for each
     # global interface.
     for interface_name, idl_filename in interface_name_idl_filename:
         constructors = interface_name_to_constructors(interface_name)
         write_global_constructors_partial_interface(
             interface_name, idl_filename, constructors)
 
 
 if __name__ == '__main__':
     sys.exit(main())