Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2435953002: Add CodeStubAssembler::FlattenString (Closed)

Created:
4 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 1 month ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add CodeStubAssembler::FlattenString R=danno@chromium.org BUG= Committed: https://crrev.com/9780e970ff444c68064b7c5ef1cf64d0000e13e9 Cr-Commit-Position: refs/heads/master@{#40456}

Patch Set 1 #

Total comments: 2

Patch Set 2 : deferred block #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
M src/code-stub-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
jochen (gone - plz use gerrit)
4 years, 2 months ago (2016-10-20 07:12:27 UTC) #1
jochen (gone - plz use gerrit)
I'm working towards writing a TF builtin for String.prototype.indexOf btw
4 years, 2 months ago (2016-10-20 07:13:02 UTC) #2
danno
lgtm with nits https://chromiumcodereview.appspot.com/2435953002/diff/1/src/code-stub-assembler.cc File src/code-stub-assembler.cc (right): https://chromiumcodereview.appspot.com/2435953002/diff/1/src/code-stub-assembler.cc#newcode3613 src/code-stub-assembler.cc:3613: result.Bind(CallRuntime(Runtime::kToString, context, input)); After our discussion, ...
4 years, 2 months ago (2016-10-20 08:35:53 UTC) #9
jochen (gone - plz use gerrit)
done
4 years, 2 months ago (2016-10-20 08:42:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435953002/20001
4 years, 2 months ago (2016-10-20 08:42:47 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 08:48:04 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:29 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9780e970ff444c68064b7c5ef1cf64d0000e13e9
Cr-Commit-Position: refs/heads/master@{#40456}

Powered by Google App Engine
This is Rietveld 408576698