Further refactoring of SBER1 preference usage.

Further refactoring of SBER1 preference usage.

Added Set and Exists methods to safe_browsing_prefs and updated callers.

BUG=653122
Committed: https://crrev.com/412a44968e3471916f162081dea71e363056eedf
Cr-Commit-Position: refs/heads/master@{#426825}

[lpz, 2016-10-20 19:51:39]

The CQ bit was checked by lpz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 19:52:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpz, 2016-10-20 19:54:30]

The CQ bit was checked by lpz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 19:54:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpz, 2016-10-20 20:22:35]

lpz@chromium.org changed reviewers:
+ jialiul@chromium.org, msw@chromium.org

[lpz, 2016-10-20 20:22:36]

msw@chromium.org: Please review changes in c/b/ui/views

jialiul@chromium.org: Please review changes in safe_browsing

[Jialiu Lin, 2016-10-20 21:11:09]

lgtm for c/b/safe_browsing/

[commit-bot: I haz the power, 2016-10-20 21:12:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 21:12:53]

Dry run: This issue passed the CQ dry run.

[vakh (use Gerrit instead), 2016-10-20 21:14:43]

vakh@chromium.org changed reviewers:
+ vakh@chromium.org

[vakh (use Gerrit instead), 2016-10-20 21:14:44]

lgtm

https://codereview.chromium.org/2435933003/diff/20001/components/safe_browsin...
File components/safe_browsing_db/safe_browsing_prefs.h (right):

https://codereview.chromium.org/2435933003/diff/20001/components/safe_browsin...
components/safe_browsing_db/safe_browsing_prefs.h:32: void
SetExtendedReportingPref(PrefService* prefs, bool value);
Nit (feel free to ignore): I would encourage you to have these functions in
alphabetical order.

[msw, 2016-10-20 21:55:51]

c/b/ui/views lgtm

[lpz, 2016-10-21 16:18:27]

Thanks!

https://codereview.chromium.org/2435933003/diff/20001/components/safe_browsin...
File components/safe_browsing_db/safe_browsing_prefs.h (right):

https://codereview.chromium.org/2435933003/diff/20001/components/safe_browsin...
components/safe_browsing_db/safe_browsing_prefs.h:32: void
SetExtendedReportingPref(PrefService* prefs, bool value);
On 2016/10/20 21:14:43, vakh (Varun Khaneja) wrote:
> Nit (feel free to ignore): I would encourage you to have these functions in
> alphabetical order.

Done.

[lpz, 2016-10-21 16:18:33]

The CQ bit was checked by lpz@chromium.org

[lpz, 2016-10-21 16:18:33]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
vakh@chromium.org, jialiul@chromium.org
Link to the patchset: https://codereview.chromium.org/2435933003/#ps40001
(title: "Order functions alphabetically.")

[commit-bot: I haz the power, 2016-10-21 16:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 17:19:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 17:36:13]

Description was changed from

==========
Further refactoring of SBER1 preference usage.

Added Set and Exists methods to safe_browsing_prefs and updated callers.

BUG=653122
==========

to

==========
Further refactoring of SBER1 preference usage.

Added Set and Exists methods to safe_browsing_prefs and updated callers.

BUG=653122

Committed: https://crrev.com/412a44968e3471916f162081dea71e363056eedf
Cr-Commit-Position: refs/heads/master@{#426825}
==========

[commit-bot: I haz the power, 2016-10-21 17:36:14]

Patchset 3 (id:??) landed as
https://crrev.com/412a44968e3471916f162081dea71e363056eedf
Cr-Commit-Position: refs/heads/master@{#426825}