Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Side by Side Diff: components/safe_browsing_db/safe_browsing_prefs.cc

Issue 2435933003: Further refactoring of SBER1 preference usage. (Closed)
Patch Set: Order functions alphabetically. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/safe_browsing_db/safe_browsing_prefs.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/metrics/histogram_macros.h" 5 #include "base/metrics/histogram_macros.h"
6 #include "components/prefs/pref_service.h" 6 #include "components/prefs/pref_service.h"
7 #include "components/safe_browsing_db/safe_browsing_prefs.h" 7 #include "components/safe_browsing_db/safe_browsing_prefs.h"
8 8
9 namespace prefs { 9 namespace prefs {
10 10
11 // Boolean that tell us whether Safe Browsing extended reporting is enabled. 11 // Boolean that tell us whether Safe Browsing extended reporting is enabled.
12 const char kSafeBrowsingExtendedReportingEnabled[] = 12 const char kSafeBrowsingExtendedReportingEnabled[] =
13 "safebrowsing.extended_reporting_enabled"; 13 "safebrowsing.extended_reporting_enabled";
14 14
15 } // namespace prefs 15 } // namespace prefs
16 16
17 namespace safe_browsing { 17 namespace safe_browsing {
18 18
19 bool ExtendedReportingPrefExists(const PrefService& prefs) {
20 return prefs.HasPrefPath(GetExtendedReportingPrefName());
21 }
22
19 const char* GetExtendedReportingPrefName() { 23 const char* GetExtendedReportingPrefName() {
20 return prefs::kSafeBrowsingExtendedReportingEnabled; 24 return prefs::kSafeBrowsingExtendedReportingEnabled;
21 } 25 }
22 26
23 bool IsExtendedReportingEnabled(const PrefService& prefs) { 27 bool IsExtendedReportingEnabled(const PrefService& prefs) {
24 return prefs.GetBoolean(GetExtendedReportingPrefName()); 28 return prefs.GetBoolean(GetExtendedReportingPrefName());
25 } 29 }
26 30
27 void RecordExtendedReportingMetrics(const PrefService& prefs) { 31 void RecordExtendedReportingMetrics(const PrefService& prefs) {
28 UMA_HISTOGRAM_BOOLEAN("SafeBrowsing.Pref.Extended", 32 UMA_HISTOGRAM_BOOLEAN("SafeBrowsing.Pref.Extended",
29 IsExtendedReportingEnabled(prefs)); 33 IsExtendedReportingEnabled(prefs));
30 } 34 }
31 35
36 void SetExtendedReportingPref(PrefService* prefs, bool value) {
37 prefs->SetBoolean(GetExtendedReportingPrefName(), value);
38 }
39
32 } // namespace safe_browsing 40 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « components/safe_browsing_db/safe_browsing_prefs.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698