Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2435153004: Change Service contract to pass ServiceInfo instead of Identity (Closed)

Created:
4 years, 2 months ago by Ben Goodger (Google)
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, kalyank, posciak+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sadrul, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change Service contract to pass ServiceInfo instead of Identity R=rockot@chromium.org Committed: https://crrev.com/5d37ee7216cbf8fd95f78377e4f152f68f50ce36 Cr-Commit-Position: refs/heads/master@{#427430}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 1

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -191 lines) Patch
M ash/autoclick/mus/autoclick_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/autoclick/mus/autoclick_application.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ash/mus/window_manager_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/mus/window_manager_application.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M ash/touch_hud/mus/touch_hud_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/filesystem/file_system_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/font_service/font_service_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/font_service/font_service_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/leveldb/leveldb_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/service_manager/service_manager_connection_impl.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/public/test/test_service.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/app_driver/app_driver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/app_driver/app_driver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/browser/browser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/browser/browser.cc View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M mash/catalog_viewer/catalog_viewer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/catalog_viewer/catalog_viewer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mash/example/views_examples/views_examples.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/init/init.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/init/init.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/login/login.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M mash/package/mash_packaged_service.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/package/mash_packaged_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/quick_launch/quick_launch.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/quick_launch/quick_launch.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mash/screenlock/screenlock.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M mash/session/session.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/session/session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/task_viewer/task_viewer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mash/webtest/webtest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/webtest/webtest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/mojo/services/media_service.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/media_service.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M services/catalog/catalog.h View 1 chunk +1 line, -1 line 0 comments Download
M services/catalog/catalog.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/file/file_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/file/file_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/service_manager/background/tests/test_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/public/cpp/lib/service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/service_manager/public/cpp/service.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M services/service_manager/public/cpp/service_test.h View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/service_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/service_manager.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M services/service_manager/tests/connect/connect_test_app.cc View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M services/service_manager/tests/connect/connect_test_class_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/service_manager/tests/connect/connect_test_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/connect/connect_test_exe.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/service_manager/tests/connect/connect_test_package.cc View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
M services/service_manager/tests/connect/connect_test_singleton_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/connect/connect_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/app_client.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/app_client.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/package.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M services/service_manager/tests/lifecycle/parent.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/service_manager/driver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/service_manager/tests/service_manager/service_manager_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/service_manager/target.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/service_manager/tests/shutdown/shutdown_client_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/shutdown/shutdown_service_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/service.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/demo/mus_demo_service.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/demo/mus_demo_service.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ime/test_ime_driver/test_ime_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/ime/test_ime_driver/test_ime_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/tests/window_server_shelltest_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/test_wm/test_wm.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/video_capture_service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/video_capture_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (21 generated)
Ben Goodger (Google)
4 years, 2 months ago (2016-10-20 23:27:45 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-21 00:03:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435153004/50001
4 years, 1 month ago (2016-10-25 16:09:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/180108)
4 years, 1 month ago (2016-10-25 16:16:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435153004/70001
4 years, 1 month ago (2016-10-25 16:36:53 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/180137)
4 years, 1 month ago (2016-10-25 16:59:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435153004/90001
4 years, 1 month ago (2016-10-25 17:13:15 UTC) #23
kuzminruslan
https://codereview.chromium.org/2435153004/diff/50001/services/service_manager/tests/connect/connect_test_app.cc File services/service_manager/tests/connect/connect_test_app.cc (right): https://codereview.chromium.org/2435153004/diff/50001/services/service_manager/tests/connect/connect_test_app.cc#newcode78 services/service_manager/tests/connect/connect_test_app.cc:78: connector()->ConnectToInterface(remote_identity, &caller_); not sure - remote_identity is argument old ...
4 years, 1 month ago (2016-10-25 17:24:32 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/259583)
4 years, 1 month ago (2016-10-25 17:38:36 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435153004/110001
4 years, 1 month ago (2016-10-25 17:43:48 UTC) #30
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/5d37ee7216cbf8fd95f78377e4f152f68f50ce36 Cr-Commit-Position: refs/heads/master@{#427430}
4 years, 1 month ago (2016-10-25 19:09:28 UTC) #32
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 19:09:48 UTC) #33
Message was sent while issue was closed.
Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

Powered by Google App Engine
This is Rietveld 408576698