Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 2434763002: [wrapper-tracing] Bring remoteplayback up to date (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
index 36d104c3df498dac1e3d320df2bf9a60c3e9e645..6872a3298684b9e1a6f3987518fe677472b700b5 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
@@ -40,6 +40,15 @@
namespace blink {
+class CORE_EXPORT TraceWrapperBase {
Michael Lippautz 2016/10/19 12:20:21 We could use this super class in cases where the e
Marcel Hlopko 2016/10/19 15:08:17 Nit: TraceWrappersBase?
haraken 2016/10/19 15:31:43 Maybe we should unify TraceWrappers and TraceWrapp
Michael Lippautz 2016/10/19 15:44:34 Will do renaming, and inheriting changes to Script
+ WTF_MAKE_NONCOPYABLE(TraceWrapperBase);
+
+ public:
+ TraceWrapperBase() = default;
+
+ DECLARE_VIRTUAL_TRACE_WRAPPERS(){};
+};
+
// ScriptWrappable provides a way to map from/to C++ DOM implementation to/from
// JavaScript object (platform object). toV8() converts a ScriptWrappable to
// a v8::Object and toScriptWrappable() converts a v8::Object back to

Powered by Google App Engine
This is Rietveld 408576698