[wrapper-tracing] Bring remoteplayback up to date

third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 22 matching lines @@
 
 #include "bindings/core/v8/WrapperTypeInfo.h"
 #include "core/CoreExport.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/TypeTraits.h"
 #include <v8.h>
 
 namespace blink {
 
+class CORE_EXPORT TraceWrapperBase {

[Michael Lippautz, 2016/10/19 12:20:21]

We could use this super class in cases where the extra vtable pointer doesn't
matter or we cannot properly include because of component builds.

A future CL could also make it a base class for ScriptWrappable, getting rid of
the special visitor code.

[Marcel Hlopko, 2016/10/19 15:08:17]

Nit: TraceWrappersBase?

[haraken, 2016/10/19 15:31:43]

Maybe we should unify TraceWrappers and TraceWrapper into one of the two. We
have TraceWrapperMember. We have TRACE_WRAPPERS.

I'd slightly prefer TraceWrapper but anyway a follow-up CL is fine.

[Michael Lippautz, 2016/10/19 15:44:34]

Will do renaming, and inheriting changes to ScriptWrappable in a followup CL.

+  WTF_MAKE_NONCOPYABLE(TraceWrapperBase);
+
+ public:
+  TraceWrapperBase() = default;
+
+  DECLARE_VIRTUAL_TRACE_WRAPPERS(){};
+};
+
 // ScriptWrappable provides a way to map from/to C++ DOM implementation to/from
 // JavaScript object (platform object).  toV8() converts a ScriptWrappable to
 // a v8::Object and toScriptWrappable() converts a v8::Object back to
 // a ScriptWrappable.  v8::Object as platform object is called "wrapper object".
 // The wrapepr object for the main world is stored in ScriptWrappable.  Wrapper
 // objects for other worlds are stored in DOMWrapperMap.
 class CORE_EXPORT ScriptWrappable {
   WTF_MAKE_NONCOPYABLE(ScriptWrappable);
 
  public:
@@ skipping 145 matching lines @@
 #define DECLARE_WRAPPERTYPEINFO()                          \
  public:                                                   \
   const WrapperTypeInfo* wrapperTypeInfo() const override; \
                                                            \
  private:                                                  \
   typedef void end_of_define_wrappertypeinfo_not_reached_t
 
 }  // namespace blink
 
 #endif  // ScriptWrappable_h