Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2434753003: [cleanup] Delete MacroAssembler::CopyBytes, it is dead code (Closed)

Created:
4 years, 2 months ago by Jakob Kummerow
Modified:
4 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Delete MacroAssembler::CopyBytes, it is dead code Committed: https://crrev.com/818d61ab2890e22a13255b617e855443de3c68a6 Cr-Commit-Position: refs/heads/master@{#40459}

Patch Set 1 #

Patch Set 2 : update .golden files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -945 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 1 10 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 2 chunks +0 lines, -91 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 2 chunks +0 lines, -91 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Jakob Kummerow
:-)
4 years, 2 months ago (2016-10-19 17:07:18 UTC) #2
Igor Sheludko
lgtm
4 years, 2 months ago (2016-10-19 17:08:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434753003/1
4 years, 2 months ago (2016-10-19 17:09:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11154) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-19 17:31:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434753003/20001
4 years, 2 months ago (2016-10-20 09:42:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 10:15:25 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:36 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/818d61ab2890e22a13255b617e855443de3c68a6
Cr-Commit-Position: refs/heads/master@{#40459}

Powered by Google App Engine
This is Rietveld 408576698