Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: src/s390/macro-assembler-s390.cc

Issue 2434753003: [cleanup] Delete MacroAssembler::CopyBytes, it is dead code (Closed)
Patch Set: update .golden files Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/s390/macro-assembler-s390.h ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/s390/macro-assembler-s390.cc
diff --git a/src/s390/macro-assembler-s390.cc b/src/s390/macro-assembler-s390.cc
index 31409bdd7965414a5a6de9c6f0b109599f7f26e2..97bade1f876ef51efc517a72e71475a8669e6bd0 100644
--- a/src/s390/macro-assembler-s390.cc
+++ b/src/s390/macro-assembler-s390.cc
@@ -2921,51 +2921,6 @@ void MacroAssembler::AllocateJSValue(Register result, Register constructor,
STATIC_ASSERT(JSValue::kSize == 4 * kPointerSize);
}
-void MacroAssembler::CopyBytes(Register src, Register dst, Register length,
- Register scratch) {
- Label big_loop, left_bytes, done, fake_call;
-
- DCHECK(!scratch.is(r0));
-
- // big loop moves 256 bytes at a time
- bind(&big_loop);
- CmpP(length, Operand(static_cast<intptr_t>(0x100)));
- blt(&left_bytes);
-
- mvc(MemOperand(dst), MemOperand(src), 0x100);
-
- AddP(src, Operand(static_cast<intptr_t>(0x100)));
- AddP(dst, Operand(static_cast<intptr_t>(0x100)));
- SubP(length, Operand(static_cast<intptr_t>(0x100)));
- b(&big_loop);
-
- bind(&left_bytes);
- CmpP(length, Operand::Zero());
- beq(&done);
-
- // TODO(john.yan): More optimal version is to use MVC
- // Sequence below has some undiagnosed issue.
- /*
- b(scratch, &fake_call); // use brasl to Save mvc addr to scratch
- mvc(MemOperand(dst), MemOperand(src), 1);
- bind(&fake_call);
- SubP(length, Operand(static_cast<intptr_t>(-1)));
- ex(length, MemOperand(scratch)); // execute mvc instr above
- AddP(src, length);
- AddP(dst, length);
- AddP(src, Operand(static_cast<intptr_t>(0x1)));
- AddP(dst, Operand(static_cast<intptr_t>(0x1)));
- */
-
- mvc(MemOperand(dst), MemOperand(src), 1);
- AddP(src, Operand(static_cast<intptr_t>(0x1)));
- AddP(dst, Operand(static_cast<intptr_t>(0x1)));
- SubP(length, Operand(static_cast<intptr_t>(0x1)));
-
- b(&left_bytes);
- bind(&done);
-}
-
void MacroAssembler::InitializeNFieldsWithFiller(Register current_address,
Register count,
Register filler) {
« no previous file with comments | « src/s390/macro-assembler-s390.h ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698