Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2434583002: Mojofy unittests: ServiceWorkerVersionTest (Closed)

Created:
4 years, 2 months ago by shimazu
Modified:
4 years, 2 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojofy unittests: ServiceWorkerVersionTest This patch mojofies five unittests: - ServiceWorkerVersionTest - ServiceWorkerFailToStartTest - ServiceWorkerNavigationHintUMATest - ServiceWorkerStallInStoppingTest - ServiceWorkerVersionWithMojoTest In this patch, InterfaceProvider/InterfaceRegistry are initialized at StartWorker when enabling mojo for the service workers. BUG=629701 TEST=./out/Debug/content_unittests -f --gtest_filter="ServiceWorkerStallInStoppingTest*" TEST=./out/Debug/content_unittests -f --gtest_filter="ServiceWorkerNavigationHintUMATest*" TEST=./out/Debug/content_unittests -f --gtest_filter="ServiceWorkerFailToStartTest*" TEST=./out/Debug/content_unittests -f --gtest_filter="ServiceWorkerVersion*" Committed: https://crrev.com/cc7bbd0f860eff108cc992153ef6fc56ed22cc8b Cr-Commit-Position: refs/heads/master@{#426394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -67 lines) Patch
M content/browser/service_worker/embedded_worker_test_helper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +14 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 43 chunks +94 lines, -49 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
shimazu
ptal
4 years, 2 months ago (2016-10-19 05:22:09 UTC) #2
horo
lgtm
4 years, 2 months ago (2016-10-19 07:21:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434583002/1
4 years, 2 months ago (2016-10-20 01:48:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 03:48:19 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:15:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc7bbd0f860eff108cc992153ef6fc56ed22cc8b
Cr-Commit-Position: refs/heads/master@{#426394}

Powered by Google App Engine
This is Rietveld 408576698