Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2431313003: Mojofy unittests related to service workers (Closed)

Created:
4 years, 2 months ago by shimazu
Modified:
4 years, 2 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojofy unittests related to service workers This patch mojofies all of browser-side unittests which didn't fail with --mojo-service-worker flag. BUG=629701 Committed: https://crrev.com/9516b05c82cd62b522f23d3a773578d0aff33716 Cr-Commit-Position: refs/heads/master@{#426440}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -158 lines) Patch
M content/browser/service_worker/link_header_support_unittest.cc View 16 chunks +24 lines, -14 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_writer_unittest.cc View 20 chunks +26 lines, -18 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core_unittest.cc View 3 chunks +9 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler_unittest.cc View 6 chunks +12 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 8 chunks +14 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 1 29 chunks +36 lines, -26 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager_unittest.cc View 6 chunks +12 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc View 5 chunks +11 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_unittest.cc View 8 chunks +19 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 3 chunks +9 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 24 chunks +48 lines, -25 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 19 chunks +24 lines, -20 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 11 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
shimazu
This is the last patch to mojofy unittests! ptal:)
4 years, 2 months ago (2016-10-19 08:32:53 UTC) #2
horo
lgtm https://codereview.chromium.org/2431313003/diff/1/content/browser/service_worker/service_worker_job_unittest.cc File content/browser/service_worker/service_worker_job_unittest.cc (right): https://codereview.chromium.org/2431313003/diff/1/content/browser/service_worker/service_worker_job_unittest.cc#newcode1650 content/browser/service_worker/service_worker_job_unittest.cc:1650: if (is_mojo_enabled()) { This change is already in ...
4 years, 2 months ago (2016-10-20 02:25:50 UTC) #3
shimazu
Oops, removed it (rebased). https://codereview.chromium.org/2431313003/diff/1/content/browser/service_worker/service_worker_job_unittest.cc File content/browser/service_worker/service_worker_job_unittest.cc (right): https://codereview.chromium.org/2431313003/diff/1/content/browser/service_worker/service_worker_job_unittest.cc#newcode1650 content/browser/service_worker/service_worker_job_unittest.cc:1650: if (is_mojo_enabled()) { On 2016/10/20 ...
4 years, 2 months ago (2016-10-20 08:36:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431313003/40001
4 years, 2 months ago (2016-10-20 08:37:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-20 10:07:44 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:16:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9516b05c82cd62b522f23d3a773578d0aff33716
Cr-Commit-Position: refs/heads/master@{#426440}

Powered by Google App Engine
This is Rietveld 408576698