Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2434293002: Do not run Autofill RTL test on JB (Closed)

Created:
4 years, 2 months ago by kraush
Modified:
4 years, 2 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not run Autofill RTL test on JB RTL is not supported in SDK level 16. This test that relies on native RTL support should therefore be disabled. BUG=657927 Committed: https://crrev.com/a6415ebf964e91a280f4fea120ea48fcc077fd2a Cr-Commit-Position: refs/heads/master@{#426821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kraush
Hi David, Can you take a look at this change to disable an RTL test ...
4 years, 2 months ago (2016-10-20 18:18:04 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years, 2 months ago (2016-10-21 16:21:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434293002/1
4 years, 2 months ago (2016-10-21 16:22:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 17:09:58 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 17:36:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6415ebf964e91a280f4fea120ea48fcc077fd2a
Cr-Commit-Position: refs/heads/master@{#426821}

Powered by Google App Engine
This is Rietveld 408576698