Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java

Issue 2434293002: Do not run Autofill RTL test on JB (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java
index c9c7538c7898d0548abd561494ff45ea3128154f..4517e1f473f721a1c6d270df1556898b1b379451 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.autofill;
+import android.os.Build;
import android.test.suitebuilder.annotation.MediumTest;
import android.view.View;
import android.view.ViewGroup;
@@ -13,6 +14,7 @@ import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest;
+import org.chromium.base.test.util.MinAndroidSdkLevel;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.base.test.util.UrlUtils;
import org.chromium.chrome.browser.ChromeActivity;
@@ -191,9 +193,13 @@ public class AutofillKeyboardAccessoryTest extends ChromeActivityTestCaseBase<Ch
/**
* Switching fields in RTL should re-scroll the keyboard accessory to the right.
+ *
+ * RTL is only supported on Jelly Bean MR 1+.
+ * http://android-developers.blogspot.com/2013/03/native-rtl-support-in-android-42.html
*/
@MediumTest
@Feature({"keyboard-accessory"})
+ @MinAndroidSdkLevel(Build.VERSION_CODES.JELLY_BEAN_MR1)
public void testSwitchFieldsRescrollsKeyboardAccessoryRtl() throws ExecutionException,
InterruptedException, TimeoutException {
loadTestPage(true);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698