Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2434233002: Revert of Speedup access to global_proxy.* attributes/accessors. (Closed)

Created:
4 years, 2 months ago by vogelheim
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Speedup access to global_proxy.* attributes/accessors. (patchset #6 id:160001 of https://codereview.chromium.org/2403003002/ ) Reason for revert: Revert, because of crbug.com/656959. Original issue's description: > Speedup access to global_proxy.* attributes/accessors. > > Using a global proxy (e.g. 'window.f', 'w.f' or 'this.f') is considerably slower than evaluating just 'f'. This CL aims to perform the necessary checks at compile time and inline the accesses. > > This is a follow-on CL to crrev.com/2369933005: > - The initial upload is crrev.com/2369933005 + a rebase. > - The remaining issues are the fixes requested by the reviewers on that CL. > > BUG=chromium:634276, chromium:654716 > > Committed: https://crrev.com/8f43d748272536117008aa6a1b53ea52126261c1 > Committed: https://crrev.com/041314524952a3c1bc71bd3beafbbb37319f1d22 > Cr-Original-Commit-Position: refs/heads/master@{#40153} > Cr-Commit-Position: refs/heads/master@{#40365} TBR=jochen@chromium.org,verwaest@chromium.org NOTRY=true NOPRESUBMIT=true BUG=chromium:634276, chromium:654716 Committed: https://crrev.com/9e6bfbd33cf457a4735de2ce631023ee1fb17a15 Cr-Commit-Position: refs/heads/master@{#40481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -162 lines) Patch
M src/crankshaft/hydrogen.h View 1 chunk +7 lines, -9 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 7 chunks +112 lines, -153 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
vogelheim
Created Revert of Speedup access to global_proxy.* attributes/accessors.
4 years, 2 months ago (2016-10-20 16:09:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434233002/1
4 years, 2 months ago (2016-10-20 16:09:49 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26982)
4 years, 2 months ago (2016-10-20 16:23:59 UTC) #5
Michael Hablich
On 2016/10/20 16:23:59, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-10-20 17:47:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434233002/1
4 years, 2 months ago (2016-10-20 17:48:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 17:48:23 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:08:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e6bfbd33cf457a4735de2ce631023ee1fb17a15
Cr-Commit-Position: refs/heads/master@{#40481}

Powered by Google App Engine
This is Rietveld 408576698