Revert of Speedup access to global_proxy.* attributes/accessors.

src/crankshaft/hydrogen.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/crankshaft/hydrogen.h"
 
 #include <memory>
 #include <sstream>
 
 #include "src/allocation-site-scopes.h"
@@ skipping 5430 matching lines @@
 
   if (!ast_context()->IsTest()) {
     HBasicBlock* join = CreateJoin(cond_true, cond_false, expr->id());
     set_current_block(join);
     if (join != NULL && !ast_context()->IsEffect()) {
       return ast_context()->ReturnValue(Pop());
     }
   }
 }
 
-bool HOptimizedGraphBuilder::CanInlineGlobalPropertyAccess(
-    Variable* var, LookupIterator* it, PropertyAccessType access_type) {
-  if (var->is_this()) return false;
-  return CanInlineGlobalPropertyAccess(it, access_type);
-}
 
-bool HOptimizedGraphBuilder::CanInlineGlobalPropertyAccess(
-    LookupIterator* it, PropertyAccessType access_type) {
-  if (!current_info()->has_global_object()) {
-    return false;
+HOptimizedGraphBuilder::GlobalPropertyAccess
+HOptimizedGraphBuilder::LookupGlobalProperty(Variable* var, LookupIterator* it,
+                                             PropertyAccessType access_type) {
+  if (var->is_this() || !current_info()->has_global_object()) {
+    return kUseGeneric;
   }
 
   switch (it->state()) {
     case LookupIterator::ACCESSOR:
     case LookupIterator::ACCESS_CHECK:
     case LookupIterator::INTERCEPTOR:
     case LookupIterator::INTEGER_INDEXED_EXOTIC:
     case LookupIterator::NOT_FOUND:
-      return false;
+      return kUseGeneric;
     case LookupIterator::DATA:
-      if (access_type == STORE && it->IsReadOnly()) return false;
-      if (!it->GetHolder<JSObject>()->IsJSGlobalObject()) return false;
-      return true;
+      if (access_type == STORE && it->IsReadOnly()) return kUseGeneric;
+      if (!it->GetHolder<JSObject>()->IsJSGlobalObject()) return kUseGeneric;
+      return kUseCell;
     case LookupIterator::JSPROXY:
     case LookupIterator::TRANSITION:
       UNREACHABLE();
   }
   UNREACHABLE();
-  return false;
+  return kUseGeneric;
 }
 
 
 HValue* HOptimizedGraphBuilder::BuildContextChainWalk(Variable* var) {
   DCHECK(var->IsContextSlot());
   HValue* context = environment()->context();
   int length = scope()->ContextChainLength(var->scope());
   while (length-- > 0) {
     context = Add<HLoadNamedField>(
         context, nullptr,
         HObjectAccess::ForContextSlot(Context::PREVIOUS_INDEX));
   }
   return context;
 }
 
-void HOptimizedGraphBuilder::InlineGlobalPropertyLoad(LookupIterator* it,
-                                                      BailoutId ast_id) {
-  Handle<PropertyCell> cell = it->GetPropertyCell();
-  top_info()->dependencies()->AssumePropertyCell(cell);
-  auto cell_type = it->property_details().cell_type();
-  if (cell_type == PropertyCellType::kConstant ||
-      cell_type == PropertyCellType::kUndefined) {
-    Handle<Object> constant_object(cell->value(), isolate());
-    if (constant_object->IsConsString()) {
-      constant_object = String::Flatten(Handle<String>::cast(constant_object));
-    }
-    HConstant* constant = New<HConstant>(constant_object);
-    return ast_context()->ReturnInstruction(constant, ast_id);
-  } else {
-    auto access = HObjectAccess::ForPropertyCellValue();
-    UniqueSet<Map>* field_maps = nullptr;
-    if (cell_type == PropertyCellType::kConstantType) {
-      switch (cell->GetConstantType()) {
-        case PropertyCellConstantType::kSmi:
-          access = access.WithRepresentation(Representation::Smi());
-          break;
-        case PropertyCellConstantType::kStableMap: {
-          // Check that the map really is stable. The heap object could
-          // have mutated without the cell updating state. In that case,
-          // make no promises about the loaded value except that it's a
-          // heap object.
-          access = access.WithRepresentation(Representation::HeapObject());
-          Handle<Map> map(HeapObject::cast(cell->value())->map());
-          if (map->is_stable()) {
-            field_maps = new (zone())
-                UniqueSet<Map>(Unique<Map>::CreateImmovable(map), zone());
-          }
-          break;
-        }
-      }
-    }
-    HConstant* cell_constant = Add<HConstant>(cell);
-    HLoadNamedField* instr;
-    if (field_maps == nullptr) {
-      instr = New<HLoadNamedField>(cell_constant, nullptr, access);
-    } else {
-      instr = New<HLoadNamedField>(cell_constant, nullptr, access, field_maps,
-                                   HType::HeapObject());
-    }
-    instr->ClearDependsOnFlag(kInobjectFields);
-    instr->SetDependsOnFlag(kGlobalVars);
-    return ast_context()->ReturnInstruction(instr, ast_id);
-  }
-}
 
 void HOptimizedGraphBuilder::VisitVariableProxy(VariableProxy* expr) {
   DCHECK(!HasStackOverflow());
   DCHECK(current_block() != NULL);
   DCHECK(current_block()->HasPredecessor());
   Variable* variable = expr->var();
   switch (variable->location()) {
     case VariableLocation::UNALLOCATED: {
       if (IsLexicalVariableMode(variable->mode())) {
         // TODO(rossberg): should this be an DCHECK?
@@ skipping 28 matching lines @@
             return Bailout(kReferenceToUninitializedVariable);
           }
           HInstruction* result = New<HLoadNamedField>(
               Add<HConstant>(script_context), nullptr,
               HObjectAccess::ForContextSlot(lookup.slot_index));
           return ast_context()->ReturnInstruction(result, expr->id());
         }
       }
 
       LookupIterator it(global, variable->name(), LookupIterator::OWN);
-      if (CanInlineGlobalPropertyAccess(variable, &it, LOAD)) {
-        InlineGlobalPropertyLoad(&it, expr->id());
-        return;
+      GlobalPropertyAccess type = LookupGlobalProperty(variable, &it, LOAD);
+
+      if (type == kUseCell) {
+        Handle<PropertyCell> cell = it.GetPropertyCell();
+        top_info()->dependencies()->AssumePropertyCell(cell);
+        auto cell_type = it.property_details().cell_type();
+        if (cell_type == PropertyCellType::kConstant ||
+            cell_type == PropertyCellType::kUndefined) {
+          Handle<Object> constant_object(cell->value(), isolate());
+          if (constant_object->IsConsString()) {
+            constant_object =
+                String::Flatten(Handle<String>::cast(constant_object));
+          }
+          HConstant* constant = New<HConstant>(constant_object);
+          return ast_context()->ReturnInstruction(constant, expr->id());
+        } else {
+          auto access = HObjectAccess::ForPropertyCellValue();
+          UniqueSet<Map>* field_maps = nullptr;
+          if (cell_type == PropertyCellType::kConstantType) {
+            switch (cell->GetConstantType()) {
+              case PropertyCellConstantType::kSmi:
+                access = access.WithRepresentation(Representation::Smi());
+                break;
+              case PropertyCellConstantType::kStableMap: {
+                // Check that the map really is stable. The heap object could
+                // have mutated without the cell updating state. In that case,
+                // make no promises about the loaded value except that it's a
+                // heap object.
+                access =
+                    access.WithRepresentation(Representation::HeapObject());
+                Handle<Map> map(HeapObject::cast(cell->value())->map());
+                if (map->is_stable()) {
+                  field_maps = new (zone())
+                      UniqueSet<Map>(Unique<Map>::CreateImmovable(map), zone());
+                }
+                break;
+              }
+            }
+          }
+          HConstant* cell_constant = Add<HConstant>(cell);
+          HLoadNamedField* instr;
+          if (field_maps == nullptr) {
+            instr = New<HLoadNamedField>(cell_constant, nullptr, access);
+          } else {
+            instr = New<HLoadNamedField>(cell_constant, nullptr, access,
+                                         field_maps, HType::HeapObject());
+          }
+          instr->ClearDependsOnFlag(kInobjectFields);
+          instr->SetDependsOnFlag(kGlobalVars);
+          return ast_context()->ReturnInstruction(instr, expr->id());
+        }
       } else {
         Handle<TypeFeedbackVector> vector(current_feedback_vector(), isolate());
 
         HValue* vector_value = Add<HConstant>(vector);
         HValue* slot_value =
             Add<HConstant>(vector->GetIndex(expr->VariableFeedbackSlot()));
         Callable callable = CodeFactory::LoadGlobalICInOptimizedCode(
             isolate(), ast_context()->typeof_mode());
         HValue* stub = Add<HConstant>(callable.code());
         HValue* values[] = {slot_value, vector_value};
@@ skipping 1083 matching lines @@
   DCHECK(prop != NULL);
   CHECK_ALIVE(VisitForValue(prop->obj()));
   if (!prop->key()->IsPropertyName()) {
     CHECK_ALIVE(VisitForValue(prop->key()));
   }
   CHECK_ALIVE(VisitForValue(expr->value()));
   BuildStore(expr, prop, expr->AssignmentSlot(), expr->id(),
              expr->AssignmentId(), expr->IsUninitialized());
 }
 
-HInstruction* HOptimizedGraphBuilder::InlineGlobalPropertyStore(
-    LookupIterator* it, HValue* value, BailoutId ast_id) {
-  Handle<PropertyCell> cell = it->GetPropertyCell();
-  top_info()->dependencies()->AssumePropertyCell(cell);
-  auto cell_type = it->property_details().cell_type();
-  if (cell_type == PropertyCellType::kConstant ||
-      cell_type == PropertyCellType::kUndefined) {
-    Handle<Object> constant(cell->value(), isolate());
-    if (value->IsConstant()) {
-      HConstant* c_value = HConstant::cast(value);
-      if (!constant.is_identical_to(c_value->handle(isolate()))) {
-        Add<HDeoptimize>(DeoptimizeReason::kConstantGlobalVariableAssignment,
-                         Deoptimizer::EAGER);
-      }
-    } else {
-      HValue* c_constant = Add<HConstant>(constant);
-      IfBuilder builder(this);
-      if (constant->IsNumber()) {
-        builder.If<HCompareNumericAndBranch>(value, c_constant, Token::EQ);
-      } else {
-        builder.If<HCompareObjectEqAndBranch>(value, c_constant);
-      }
-      builder.Then();
-      builder.Else();
-      Add<HDeoptimize>(DeoptimizeReason::kConstantGlobalVariableAssignment,
-                       Deoptimizer::EAGER);
-      builder.End();
-    }
-  }
-  HConstant* cell_constant = Add<HConstant>(cell);
-  auto access = HObjectAccess::ForPropertyCellValue();
-  if (cell_type == PropertyCellType::kConstantType) {
-    switch (cell->GetConstantType()) {
-      case PropertyCellConstantType::kSmi:
-        access = access.WithRepresentation(Representation::Smi());
-        break;
-      case PropertyCellConstantType::kStableMap: {
-        // The map may no longer be stable, deopt if it's ever different from
-        // what is currently there, which will allow for restablization.
-        Handle<Map> map(HeapObject::cast(cell->value())->map());
-        Add<HCheckHeapObject>(value);
-        value = Add<HCheckMaps>(value, map);
-        access = access.WithRepresentation(Representation::HeapObject());
-        break;
-      }
-    }
-  }
-  HInstruction* instr = New<HStoreNamedField>(cell_constant, access, value);
-  instr->ClearChangesFlag(kInobjectFields);
-  instr->SetChangesFlag(kGlobalVars);
-  return instr;
-}
 
 // Because not every expression has a position and there is not common
 // superclass of Assignment and CountOperation, we cannot just pass the
 // owning expression instead of position and ast_id separately.
 void HOptimizedGraphBuilder::HandleGlobalVariableAssignment(
     Variable* var, HValue* value, FeedbackVectorSlot slot, BailoutId ast_id) {
   Handle<JSGlobalObject> global(current_info()->global_object());
 
   // Lookup in script contexts.
   {
@@ skipping 20 matching lines @@
           Add<HConstant>(script_context),
           HObjectAccess::ForContextSlot(lookup.slot_index), value);
       USE(instr);
       DCHECK(instr->HasObservableSideEffects());
       Add<HSimulate>(ast_id, REMOVABLE_SIMULATE);
       return;
     }
   }
 
   LookupIterator it(global, var->name(), LookupIterator::OWN);
-  if (CanInlineGlobalPropertyAccess(var, &it, STORE)) {
-    HInstruction* instr = InlineGlobalPropertyStore(&it, value, ast_id);
-    AddInstruction(instr);
+  GlobalPropertyAccess type = LookupGlobalProperty(var, &it, STORE);
+  if (type == kUseCell) {
+    Handle<PropertyCell> cell = it.GetPropertyCell();
+    top_info()->dependencies()->AssumePropertyCell(cell);
+    auto cell_type = it.property_details().cell_type();
+    if (cell_type == PropertyCellType::kConstant ||
+        cell_type == PropertyCellType::kUndefined) {
+      Handle<Object> constant(cell->value(), isolate());
+      if (value->IsConstant()) {
+        HConstant* c_value = HConstant::cast(value);
+        if (!constant.is_identical_to(c_value->handle(isolate()))) {
+          Add<HDeoptimize>(DeoptimizeReason::kConstantGlobalVariableAssignment,
+                           Deoptimizer::EAGER);
+        }
+      } else {
+        HValue* c_constant = Add<HConstant>(constant);
+        IfBuilder builder(this);
+        if (constant->IsNumber()) {
+          builder.If<HCompareNumericAndBranch>(value, c_constant, Token::EQ);
+        } else {
+          builder.If<HCompareObjectEqAndBranch>(value, c_constant);
+        }
+        builder.Then();
+        builder.Else();
+        Add<HDeoptimize>(DeoptimizeReason::kConstantGlobalVariableAssignment,
+                         Deoptimizer::EAGER);
+        builder.End();
+      }
+    }
+    HConstant* cell_constant = Add<HConstant>(cell);
+    auto access = HObjectAccess::ForPropertyCellValue();
+    if (cell_type == PropertyCellType::kConstantType) {
+      switch (cell->GetConstantType()) {
+        case PropertyCellConstantType::kSmi:
+          access = access.WithRepresentation(Representation::Smi());
+          break;
+        case PropertyCellConstantType::kStableMap: {
+          // The map may no longer be stable, deopt if it's ever different from
+          // what is currently there, which will allow for restablization.
+          Handle<Map> map(HeapObject::cast(cell->value())->map());
+          Add<HCheckHeapObject>(value);
+          value = Add<HCheckMaps>(value, map);
+          access = access.WithRepresentation(Representation::HeapObject());
+          break;
+        }
+      }
+    }
+    HInstruction* instr = Add<HStoreNamedField>(cell_constant, access, value);
+    instr->ClearChangesFlag(kInobjectFields);
+    instr->SetChangesFlag(kGlobalVars);
     if (instr->HasObservableSideEffects()) {
       Add<HSimulate>(ast_id, REMOVABLE_SIMULATE);
     }
   } else {
     HValue* global_object = Add<HLoadNamedField>(
         BuildGetNativeContext(), nullptr,
         HObjectAccess::ForContextSlot(Context::EXTENSION_INDEX));
     Handle<TypeFeedbackVector> vector =
         handle(current_feedback_vector(), isolate());
     HValue* name = Add<HConstant>(var->name());
@@ skipping 902 matching lines @@
 
 HValue* HOptimizedGraphBuilder::BuildNamedAccess(
     PropertyAccessType access, BailoutId ast_id, BailoutId return_id,
     Expression* expr, FeedbackVectorSlot slot, HValue* object,
     Handle<Name> name, HValue* value, bool is_uninitialized) {
   SmallMapList* maps;
   ComputeReceiverTypes(expr, object, &maps, this);
   DCHECK(maps != NULL);
 
   if (maps->length() > 0) {
-    Handle<JSGlobalObject> global_object(current_info()->global_object());
-    Handle<Context> current_context(current_info()->context());
-    Handle<JSObject> global_proxy(current_context->global_proxy());
-
-    // Check for special case: Access via a single map to the global proxy
-    // can also be handled monomorphically.
-    Handle<Object> map_constructor =
-        handle(maps->first()->GetConstructor(), isolate());
-    if (map_constructor->IsJSFunction()) {
-      Handle<Context> map_context =
-          handle(Handle<JSFunction>::cast(map_constructor)->context());
-      bool is_global_proxy_access =
-          maps->length() == 1 &&  // More than one map, fallback to polymorphic?
-          maps->first()->IsJSGlobalProxyMap() &&
-          isolate()->MayAccess(map_context, global_proxy);
-
-      if (is_global_proxy_access) {
-        LookupIterator it(global_object, name, LookupIterator::OWN);
-        if (CanInlineGlobalPropertyAccess(&it, access)) {
-          BuildCheckHeapObject(object);
-          Add<HCheckMaps>(object, maps);
-          if (access == LOAD) {
-            InlineGlobalPropertyLoad(&it, expr->id());
-            return nullptr;
-          } else {
-            return InlineGlobalPropertyStore(&it, value, expr->id());
-          }
-        }
-      }
-    }
-
     PropertyAccessInfo info(this, access, maps->first(), name);
     if (!info.CanAccessAsMonomorphic(maps)) {
       HandlePolymorphicNamedFieldAccess(access, expr, slot, ast_id, return_id,
                                         object, value, maps, name);
       return NULL;
     }
 
     HValue* checked_object;
     // AstType::Number() is only supported by polymorphic load/call handling.
     DCHECK(!info.IsNumberType());
@@ skipping 5572 matching lines @@
     isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
   }
 
 #ifdef DEBUG
   graph_->Verify(false);  // No full verify.
 #endif
 }
 
 }  // namespace internal
 }  // namespace v8