Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2433333002: [ic] Refactoring definition of a smi-encoded load handlers. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Refactoring definition of a smi-encoded load handlers. BUG= Committed: https://crrev.com/9e720e3fdd985e3cd99793ec7cb4e5b54c84a59f Cr-Commit-Position: refs/heads/master@{#40469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -80 lines) Patch
M src/code-stub-assembler.cc View 5 chunks +14 lines, -11 lines 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ic/handler-configuration.h View 1 chunk +44 lines, -44 lines 0 comments Download
M src/ic/handler-configuration-inl.h View 1 chunk +17 lines, -18 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-20 09:52:46 UTC) #4
Jakob Kummerow
lgtm
4 years, 2 months ago (2016-10-20 11:48:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433333002/1
4 years, 2 months ago (2016-10-20 12:41:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 12:45:11 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:08:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e720e3fdd985e3cd99793ec7cb4e5b54c84a59f
Cr-Commit-Position: refs/heads/master@{#40469}

Powered by Google App Engine
This is Rietveld 408576698