Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2436893003: [stubs] Cleanup CSA::BitFieldDecode() and friends. (Closed)

Created:
4 years, 2 months ago by Igor Sheludko
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Cleanup CSA::BitFieldDecode(..) and friends. This CL also introduces IsSetWord<T>(..) and IsSetWord32<T>(..) operations to ease checking if the bit field is set or not. BUG= Committed: https://crrev.com/54194b2d8de76961f8c74ef35c94b32c3a7e3818 Cr-Commit-Position: refs/heads/master@{#40466}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -83 lines) Patch
M src/builtins/builtins-number.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/code-stub-assembler.h View 1 1 chunk +31 lines, -6 lines 0 comments Download
M src/code-stub-assembler.cc View 17 chunks +61 lines, -60 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Igor Sheludko
PTAL
4 years, 2 months ago (2016-10-20 09:13:15 UTC) #7
Jakob Kummerow
lgtm https://codereview.chromium.org/2436893003/diff/20001/src/code-stub-assembler.h File src/code-stub-assembler.h (right): https://codereview.chromium.org/2436893003/diff/20001/src/code-stub-assembler.h#newcode681 src/code-stub-assembler.h:681: // Decodes an unsigned (!) value from |word| ...
4 years, 2 months ago (2016-10-20 10:41:16 UTC) #10
Michael Starzinger
LGTM on "interpreter".
4 years, 2 months ago (2016-10-20 10:49:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2436893003/40001
4 years, 2 months ago (2016-10-20 11:35:58 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-20 12:27:24 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:59 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54194b2d8de76961f8c74ef35c94b32c3a7e3818
Cr-Commit-Position: refs/heads/master@{#40466}

Powered by Google App Engine
This is Rietveld 408576698