Add passive and FOV-locked properties to UI elements.

Add passive and FOV-locked properties to UI elements.

- Passive implies visible, but ignoring input.
- Field-of-view locked implies that the element is rendered relative to
  the field of view, independent of the head pose.  This lets the HTML
  UI place elements like a HUD.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5b00148c7f200318663d4f8cf887427941e94544
Cr-Commit-Position: refs/heads/master@{#426796}

[cjgrant, 2016-10-19 19:48:57]

Description was changed from

==========
Add passive and FOV-locked properties to UI elements.

- Passive implies visible, but ignoring input.
- Field-of-view locked implies that the element is rendered relative to
  the field of view, independent of the head pose.  This lets the HTML
  UI place elements like a HUD.

BUG=641508
==========

to

==========
Add passive and FOV-locked properties to UI elements.

- Passive implies visible, but ignoring input.
- Field-of-view locked implies that the element is rendered relative to
  the field of view, independent of the head pose.  This lets the HTML
  UI place elements like a HUD.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[cjgrant, 2016-10-19 19:55:27]

cjgrant@chromium.org changed reviewers:
+ bshe@chromium.org, mthiesse@chromium.org

[cjgrant, 2016-10-19 19:55:27]

A bit of contents on FOV-locking (which lets us render the WebVR warnings using
the HTML UI)...  Another way to do this is to create a dummy object, apply the
head pose to its transformations, then make real FOV-locked elements children of
this object.  To me that seemed hacky compared to just skipping the head-pose
transform for select elements.  Feel free to debate...

[mthiesse, 2016-10-20 18:15:32]

https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_elements.h (right):

https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_elements.h:77: bool passive = false;
I think a more common property would be something like hit_test_visible or
hit_test_enabled. Passive isn't very descriptive.

https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:480: gvr::Mat4f head_matrix =
MatrixMul(eye_matrix, head_pose);
why the rename from view_matrix to head_matrix? head_matrix already means
something else (you just got the eye matrix from something called the
HeadMatrix)

[bshe, 2016-10-20 22:18:23]

On 2016/10/20 18:15:32, mthiesse wrote:
>
https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
> File chrome/browser/android/vr_shell/ui_elements.h (right):
> 
>
https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
> chrome/browser/android/vr_shell/ui_elements.h:77: bool passive = false;
> I think a more common property would be something like hit_test_visible or
> hit_test_enabled. Passive isn't very descriptive.
> 
>
https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
> File chrome/browser/android/vr_shell/vr_shell.cc (right):
> 
>
https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
> chrome/browser/android/vr_shell/vr_shell.cc:480: gvr::Mat4f head_matrix =
> MatrixMul(eye_matrix, head_pose);
> why the rename from view_matrix to head_matrix? head_matrix already means
> something else (you just got the eye matrix from something called the
> HeadMatrix)

lgtm with Micheal's comments addressed

[cjgrant, 2016-10-21 14:14:50]

https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_elements.h (right):

https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_elements.h:77: bool passive = false;
On 2016/10/20 18:15:31, mthiesse wrote:
> I think a more common property would be something like hit_test_visible or
> hit_test_enabled. Passive isn't very descriptive.

Done.

https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2433253002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:480: gvr::Mat4f head_matrix =
MatrixMul(eye_matrix, head_pose);
On 2016/10/20 18:15:32, mthiesse wrote:
> why the rename from view_matrix to head_matrix? head_matrix already means
> something else (you just got the eye matrix from something called the
> HeadMatrix)

Done.

[cjgrant, 2016-10-21 14:15:11]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2016-10-21 14:15:11]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2433253002/#ps40001
(title: "Address nits.")

[commit-bot: I haz the power, 2016-10-21 14:15:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 15:17:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 15:34:08]

Description was changed from

==========
Add passive and FOV-locked properties to UI elements.

- Passive implies visible, but ignoring input.
- Field-of-view locked implies that the element is rendered relative to
  the field of view, independent of the head pose.  This lets the HTML
  UI place elements like a HUD.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add passive and FOV-locked properties to UI elements.

- Passive implies visible, but ignoring input.
- Field-of-view locked implies that the element is rendered relative to
  the field of view, independent of the head pose.  This lets the HTML
  UI place elements like a HUD.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5b00148c7f200318663d4f8cf887427941e94544
Cr-Commit-Position: refs/heads/master@{#426796}
==========

[commit-bot: I haz the power, 2016-10-21 15:34:10]

Patchset 3 (id:??) landed as
https://crrev.com/5b00148c7f200318663d4f8cf887427941e94544
Cr-Commit-Position: refs/heads/master@{#426796}