Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2432853007:
ozone: Don't sort YV channels for CrCb formats. (Closed)
|
Created:
4 years, 2 months ago by Daniele Castagna Modified:
4 years, 2 months ago Reviewers:
reveman CC:
chromium-reviews Target Ref:
refs/pending/branch-heads/2883 Project:
chromium Visibility:
Public. |
Descriptionozone: Don't sort YV channels for CrCb formats.
After all, we decided to follow up with Khronos and it seems like
the EGL_EXT_image_dma_buf_import extension spec will be amended
so that if a CrCb format is passed, the second plane represents
Cr and the third one Cb when creating the image.
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16017
This CL reverts the logic introduced with crrev.com/2295943002
Mali drivers are being modified accordingly.
BUG=658091
,b/31469091
TEST=Ran on kevin with custom mali drivers, and on elm.
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://chromiumcodereview.appspot.com/2413853003
Cr-Commit-Position: refs/heads/master@{#426180}
(cherry picked from commit a8593dfd625a66f5e05eec78dc5be01f5d606b45)
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
dcastagna@chromium.org changed reviewers: + reveman@chromium.org
lgtm
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== ozone: Don't sort YV channels for CrCb formats. After all, we decided to follow up with Khronos and it seems like the EGL_EXT_image_dma_buf_import extension spec will be amended so that if a CrCb format is passed, the second plane represents Cr and the third one Cb when creating the image. https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16017 This CL reverts the logic introduced with crrev.com/2295943002 Mali drivers are being modified accordingly. BUG=658091,b/31469091 TEST=Ran on kevin with custom mali drivers, and on elm. Review-Url: https://chromiumcodereview.appspot.com/2413853003 Cr-Commit-Position: refs/heads/master@{#426180} (cherry picked from commit a8593dfd625a66f5e05eec78dc5be01f5d606b45) ========== to ========== ozone: Don't sort YV channels for CrCb formats. After all, we decided to follow up with Khronos and it seems like the EGL_EXT_image_dma_buf_import extension spec will be amended so that if a CrCb format is passed, the second plane represents Cr and the third one Cb when creating the image. https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16017 This CL reverts the logic introduced with crrev.com/2295943002 Mali drivers are being modified accordingly. BUG=658091,b/31469091 TEST=Ran on kevin with custom mali drivers, and on elm. NOPRESUBMIT=true Review-Url: https://chromiumcodereview.appspot.com/2413853003 Cr-Commit-Position: refs/heads/master@{#426180} (cherry picked from commit a8593dfd625a66f5e05eec78dc5be01f5d606b45) ==========
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== ozone: Don't sort YV channels for CrCb formats. After all, we decided to follow up with Khronos and it seems like the EGL_EXT_image_dma_buf_import extension spec will be amended so that if a CrCb format is passed, the second plane represents Cr and the third one Cb when creating the image. https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16017 This CL reverts the logic introduced with crrev.com/2295943002 Mali drivers are being modified accordingly. BUG=658091,b/31469091 TEST=Ran on kevin with custom mali drivers, and on elm. NOPRESUBMIT=true Review-Url: https://chromiumcodereview.appspot.com/2413853003 Cr-Commit-Position: refs/heads/master@{#426180} (cherry picked from commit a8593dfd625a66f5e05eec78dc5be01f5d606b45) ========== to ========== ozone: Don't sort YV channels for CrCb formats. After all, we decided to follow up with Khronos and it seems like the EGL_EXT_image_dma_buf_import extension spec will be amended so that if a CrCb format is passed, the second plane represents Cr and the third one Cb when creating the image. https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16017 This CL reverts the logic introduced with crrev.com/2295943002 Mali drivers are being modified accordingly. BUG=658091,b/31469091 TEST=Ran on kevin with custom mali drivers, and on elm. NOPRESUBMIT=true NOTRY=true Review-Url: https://chromiumcodereview.appspot.com/2413853003 Cr-Commit-Position: refs/heads/master@{#426180} (cherry picked from commit a8593dfd625a66f5e05eec78dc5be01f5d606b45) ==========
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
