Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2413853003: ozone: Don't sort YV channels for CrCb formats. (Closed)

Created:
4 years, 2 months ago by Daniele Castagna
Modified:
4 years, 2 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Don't sort YV channels for CrCb formats. After all, we decided to follow up with Khronos and it seems like the EGL_EXT_image_dma_buf_import extension spec will be amended so that if a CrCb format is passed, the second plane represents Cr and the third one Cb when creating the image. https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16017 This CL reverts the logic introduced with crrev.com/2295943002 Mali drivers are being modified accordingly. BUG=b/31469091 TEST=Ran on kevin with custom mali drivers. Committed: https://crrev.com/a8593dfd625a66f5e05eec78dc5be01f5d606b45 Cr-Commit-Position: refs/heads/master@{#426180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M ui/ozone/gl/gl_image_ozone_native_pixmap.cc View 2 chunks +0 lines, -41 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Daniele Castagna
4 years, 2 months ago (2016-10-12 23:35:55 UTC) #6
hoegsberg1
lgtm
4 years, 2 months ago (2016-10-13 19:59:42 UTC) #8
hoegsberg1
lgtm
4 years, 2 months ago (2016-10-13 19:59:44 UTC) #9
Daniele Castagna
+spang for ownership.
4 years, 2 months ago (2016-10-13 20:01:38 UTC) #11
spang
lgtm
4 years, 2 months ago (2016-10-13 23:25:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413853003/1
4 years, 2 months ago (2016-10-19 03:40:53 UTC) #14
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-10-19 05:43:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413853003/1
4 years, 2 months ago (2016-10-19 14:16:27 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 14:25:10 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:08:00 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8593dfd625a66f5e05eec78dc5be01f5d606b45
Cr-Commit-Position: refs/heads/master@{#426180}

Powered by Google App Engine
This is Rietveld 408576698