Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 2432483002: Do not try to pop up the account chooser if there is no browser window. (Closed)

Created:
4 years, 2 months ago by vasilii
Modified:
4 years, 2 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not try to pop up the account chooser if there is no browser window. The situation was happening during prefetch. BUG=656406 Committed: https://crrev.com/4fa5f3285b050cb2823b41320777cb52f64c9508 Cr-Commit-Position: refs/heads/master@{#426144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc View 5 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
vasilii
Hi Vaclav, please review.
4 years, 2 months ago (2016-10-18 16:58:15 UTC) #4
vabr (Chromium)
LGTM, thanks for the fix! Vaclav
4 years, 2 months ago (2016-10-19 08:36:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432483002/1
4 years, 2 months ago (2016-10-19 09:31:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 10:38:51 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:06:51 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fa5f3285b050cb2823b41320777cb52f64c9508
Cr-Commit-Position: refs/heads/master@{#426144}

Powered by Google App Engine
This is Rietveld 408576698