Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 2432483002: Do not try to pop up the account chooser if there is no browser window. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 virtual void UpdateBubbleAndIconVisibility(); 130 virtual void UpdateBubbleAndIconVisibility();
131 131
132 // Called to create the account chooser dialog. Mocked in tests. 132 // Called to create the account chooser dialog. Mocked in tests.
133 virtual AccountChooserPrompt* CreateAccountChooser( 133 virtual AccountChooserPrompt* CreateAccountChooser(
134 PasswordDialogController* controller); 134 PasswordDialogController* controller);
135 135
136 // Called to create the account chooser dialog. Mocked in tests. 136 // Called to create the account chooser dialog. Mocked in tests.
137 virtual AutoSigninFirstRunPrompt* CreateAutoSigninPrompt( 137 virtual AutoSigninFirstRunPrompt* CreateAutoSigninPrompt(
138 PasswordDialogController* controller); 138 PasswordDialogController* controller);
139 139
140 // Check if |web_contents()| is attached to some Browser. Mocked in tests.
141 virtual bool HasBrowserWindow() const;
142
140 // Overwrites the client for |passwords_data_|. 143 // Overwrites the client for |passwords_data_|.
141 void set_client(password_manager::PasswordManagerClient* client) { 144 void set_client(password_manager::PasswordManagerClient* client) {
142 passwords_data_.set_client(client); 145 passwords_data_.set_client(client);
143 } 146 }
144 147
145 // content::WebContentsObserver: 148 // content::WebContentsObserver:
146 void DidNavigateMainFrame( 149 void DidNavigateMainFrame(
147 const content::LoadCommittedDetails& details, 150 const content::LoadCommittedDetails& details,
148 const content::FrameNavigateParams& params) override; 151 const content::FrameNavigateParams& params) override;
149 void WasHidden() override; 152 void WasHidden() override;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 // Thus, OnBubbleHidden() can be called after the new one is shown. By that 190 // Thus, OnBubbleHidden() can be called after the new one is shown. By that
188 // time the internal state of ManagePasswordsUIController has nothing to do 191 // time the internal state of ManagePasswordsUIController has nothing to do
189 // with the old bubble. 192 // with the old bubble.
190 // Invalidating all the weak pointers will detach the current bubble. 193 // Invalidating all the weak pointers will detach the current bubble.
191 base::WeakPtrFactory<ManagePasswordsUIController> weak_ptr_factory_; 194 base::WeakPtrFactory<ManagePasswordsUIController> weak_ptr_factory_;
192 195
193 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController); 196 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
194 }; 197 };
195 198
196 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 199 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698