Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1840)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp

Issue 2432383002: Get rid of flat tree version of createVisibleSelection() taking two PositionInFlatTree (Closed)
Patch Set: 2016-10-20T15:59:37 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
index 614c5e41e54ebe66c43bb556d17e99d9629bd892..09825c73a1809e66f9c401ae9d9bed36e5ec4e39 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp
@@ -215,9 +215,11 @@ TEST_F(VisibleSelectionTest, ShadowCrossing) {
VisibleSelection selection =
createVisibleSelection(Position::firstPositionInNode(one),
Position::lastPositionInNode(shadowRoot));
- VisibleSelectionInFlatTree selectionInFlatTree =
- createVisibleSelection(PositionInFlatTree::firstPositionInNode(one),
- PositionInFlatTree::lastPositionInNode(host));
+ VisibleSelectionInFlatTree selectionInFlatTree = createVisibleSelection(
+ SelectionInFlatTree::Builder()
+ .collapse(PositionInFlatTree::firstPositionInNode(one))
+ .extend(PositionInFlatTree::lastPositionInNode(host))
+ .build());
EXPECT_EQ(Position(host, PositionAnchorType::BeforeAnchor),
selection.start());
@@ -245,9 +247,11 @@ TEST_F(VisibleSelectionTest, ShadowV0DistributedNodes) {
VisibleSelection selection = createVisibleSelection(
Position::firstPositionInNode(one), Position::lastPositionInNode(two));
- VisibleSelectionInFlatTree selectionInFlatTree =
- createVisibleSelection(PositionInFlatTree::firstPositionInNode(one),
- PositionInFlatTree::lastPositionInNode(two));
+ VisibleSelectionInFlatTree selectionInFlatTree = createVisibleSelection(
+ SelectionInFlatTree::Builder()
+ .collapse(PositionInFlatTree::firstPositionInNode(one))
+ .extend(PositionInFlatTree::lastPositionInNode(two))
+ .build());
EXPECT_EQ(Position(one->firstChild(), 0), selection.start());
EXPECT_EQ(Position(two->firstChild(), 2), selection.end());
@@ -287,9 +291,11 @@ TEST_F(VisibleSelectionTest, ShadowNested) {
VisibleSelection selection =
createVisibleSelection(Position::firstPositionInNode(one),
Position::lastPositionInNode(shadowRoot2));
- VisibleSelectionInFlatTree selectionInFlatTree =
- createVisibleSelection(PositionInFlatTree::firstPositionInNode(one),
- PositionInFlatTree::afterNode(eight));
+ VisibleSelectionInFlatTree selectionInFlatTree = createVisibleSelection(
+ SelectionInFlatTree::Builder()
+ .collapse(PositionInFlatTree::firstPositionInNode(one))
+ .extend(PositionInFlatTree::afterNode(eight))
+ .build());
EXPECT_EQ(Position(host, PositionAnchorType::BeforeAnchor),
selection.start());
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698