third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp - Issue 2432173005: Get rid of VisibleSelection::selectionFromContentsOfNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp

Issue 2432173005: Get rid of VisibleSelection::selectionFromContentsOfNode() (Closed)

Patch Set: 2016-10-20T17:14:18 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp

diff --git a/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp b/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp

index 3ebb888cbe680f60810a72cc801b2e8e80ab31b4..1917b43d5a586d530e55eab0dddd1bf73237ee85 100644

--- a/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp

+++ b/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp

@@ -59,7 +59,7 @@ String contentAfterPastingHTML(DummyPageHolder* pageHolder,

body->setAttribute(HTMLNames::contenteditableAttr, "true");

frame.document()->updateStyleAndLayout();

frame.selection().setSelection(

- VisibleSelection::selectionFromContentsOfNode(body));

+ SelectionInDOMTree::Builder().selectAllChildren(*body).build());

EXPECT_EQ(CaretSelection, frame.selection().getSelectionType());

EXPECT_TRUE(frame.selection().isContentEditable())

<< "We should be pasting into something editable.";

« no previous file with comments | « third_party/WebKit/Source/core/page/DragController.cpp ('k') | no next file » | no next file with comments »