third_party/WebKit/Source/core/page/DragController.cpp - Issue 2432173005: Get rid of VisibleSelection::selectionFromContentsOfNode()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/DragController.cpp

Issue 2432173005: Get rid of VisibleSelection::selectionFromContentsOfNode() (Closed)

Patch Set: 2016-10-20T17:14:18 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/DragController.cpp

diff --git a/third_party/WebKit/Source/core/page/DragController.cpp b/third_party/WebKit/Source/core/page/DragController.cpp

index 25bb2766bf30cd9a58a8ece2b74f73aa08a7c43d..da14b01642dbb0b5e2fcdbde3a70f2f5a3e3c669 100644

--- a/third_party/WebKit/Source/core/page/DragController.cpp

+++ b/third_party/WebKit/Source/core/page/DragController.cpp

@@ -1099,7 +1099,7 @@ bool DragController::startDrag(LocalFrame* src,

// the enclosing anchor element

if (Node* node = enclosingAnchorElement(src->selection().base())) {

src->selection().setSelection(

- VisibleSelection::selectionFromContentsOfNode(node));

+ SelectionInDOMTree::Builder().selectAllChildren(*node).build());

}