Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2432153003: Make sure the default CSP is used for <webview> with PlzNavigate. (Closed)

Created:
4 years, 2 months ago by jam
Modified:
4 years, 2 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure the default CSP is used for <webview> with PlzNavigate. This fixes WebViewTests/WebViewTest.Shim_TestInlineScriptFromAccessibleResources/* with PlzNavigate. BUG=504347 Committed: https://crrev.com/059a6b4108cd8a6ade942d70f5de95df1a33f6e5 Cr-Commit-Position: refs/heads/master@{#426300}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -78 lines) Patch
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_extensions_network_delegate.cc View 8 chunks +9 lines, -31 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.h View 9 chunks +0 lines, -13 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 10 chunks +23 lines, -17 lines 0 comments Download
M extensions/browser/extensions_browser_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/browser/extensions_browser_client.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/browser/url_request_util.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/url_request_util.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_network_delegate.cc View 6 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
jam
4 years, 2 months ago (2016-10-19 15:17:36 UTC) #6
Fady Samuel
lgtm + nit https://codereview.chromium.org/2432153003/diff/1/extensions/browser/url_request_util.cc File extensions/browser/url_request_util.cc (right): https://codereview.chromium.org/2432153003/diff/1/extensions/browser/url_request_util.cc#newcode137 extensions/browser/url_request_util.cc:137: if (WebViewRendererState::GetInstance()->IsGuest(info->GetChildID())) Could you please add ...
4 years, 2 months ago (2016-10-19 15:27:24 UTC) #7
jam
https://codereview.chromium.org/2432153003/diff/1/extensions/browser/url_request_util.cc File extensions/browser/url_request_util.cc (right): https://codereview.chromium.org/2432153003/diff/1/extensions/browser/url_request_util.cc#newcode137 extensions/browser/url_request_util.cc:137: if (WebViewRendererState::GetInstance()->IsGuest(info->GetChildID())) On 2016/10/19 15:27:24, Fady Samuel wrote: > ...
4 years, 2 months ago (2016-10-19 19:19:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432153003/20001
4 years, 2 months ago (2016-10-19 19:20:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432153003/20001
4 years, 2 months ago (2016-10-19 20:42:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/319910)
4 years, 2 months ago (2016-10-19 21:33:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432153003/20001
4 years, 2 months ago (2016-10-19 21:38:05 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 22:08:19 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:12:01 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/059a6b4108cd8a6ade942d70f5de95df1a33f6e5
Cr-Commit-Position: refs/heads/master@{#426300}

Powered by Google App Engine
This is Rietveld 408576698