Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 2432153003: Make sure the default CSP is used for <webview> with PlzNavigate. (Closed)
Patch Set: add comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_api.cc
diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc
index 3b7e3a9a29c2d84ed9e7b89c772a5e088107113b..829ebb512eb72d044537eb4afa30a5f800fcf704 100644
--- a/extensions/browser/api/web_request/web_request_api.cc
+++ b/extensions/browser/api/web_request/web_request_api.cc
@@ -576,10 +576,11 @@ ExtensionWebRequestEventRouter::CreateEventDetails(
int ExtensionWebRequestEventRouter::OnBeforeRequest(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request,
const net::CompletionCallback& callback,
GURL* new_url) {
+ ExtensionNavigationUIData* navigation_ui_data =
+ ExtensionsBrowserClient::Get()->GetExtensionNavigationUIData(request);
if (ShouldHideEvent(browser_context, extension_info_map, request,
navigation_ui_data)) {
return net::OK;
@@ -639,10 +640,11 @@ int ExtensionWebRequestEventRouter::OnBeforeRequest(
int ExtensionWebRequestEventRouter::OnBeforeSendHeaders(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request,
const net::CompletionCallback& callback,
net::HttpRequestHeaders* headers) {
+ ExtensionNavigationUIData* navigation_ui_data =
+ ExtensionsBrowserClient::Get()->GetExtensionNavigationUIData(request);
if (ShouldHideEvent(browser_context, extension_info_map, request,
navigation_ui_data)) {
return net::OK;
@@ -692,9 +694,10 @@ int ExtensionWebRequestEventRouter::OnBeforeSendHeaders(
void ExtensionWebRequestEventRouter::OnSendHeaders(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request,
const net::HttpRequestHeaders& headers) {
+ ExtensionNavigationUIData* navigation_ui_data =
+ ExtensionsBrowserClient::Get()->GetExtensionNavigationUIData(request);
if (ShouldHideEvent(browser_context, extension_info_map, request,
navigation_ui_data))
return;
@@ -722,12 +725,13 @@ void ExtensionWebRequestEventRouter::OnSendHeaders(
int ExtensionWebRequestEventRouter::OnHeadersReceived(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request,
const net::CompletionCallback& callback,
const net::HttpResponseHeaders* original_response_headers,
scoped_refptr<net::HttpResponseHeaders>* override_response_headers,
GURL* allowed_unsafe_redirect_url) {
+ ExtensionNavigationUIData* navigation_ui_data =
+ ExtensionsBrowserClient::Get()->GetExtensionNavigationUIData(request);
if (ShouldHideEvent(browser_context, extension_info_map, request,
navigation_ui_data)) {
return net::OK;
@@ -782,11 +786,12 @@ net::NetworkDelegate::AuthRequiredResponse
ExtensionWebRequestEventRouter::OnAuthRequired(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request,
const net::AuthChallengeInfo& auth_info,
const net::NetworkDelegate::AuthCallback& callback,
net::AuthCredentials* credentials) {
+ ExtensionNavigationUIData* navigation_ui_data =
+ ExtensionsBrowserClient::Get()->GetExtensionNavigationUIData(request);
// No browser_context means that this is for authentication challenges in the
// system context. Skip in that case. Also skip sensitive requests.
if (!browser_context ||
@@ -824,9 +829,10 @@ ExtensionWebRequestEventRouter::OnAuthRequired(
void ExtensionWebRequestEventRouter::OnBeforeRedirect(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request,
const GURL& new_location) {
+ ExtensionNavigationUIData* navigation_ui_data =
+ ExtensionsBrowserClient::Get()->GetExtensionNavigationUIData(request);
if (ShouldHideEvent(browser_context, extension_info_map, request,
navigation_ui_data)) {
return;
@@ -860,11 +866,12 @@ void ExtensionWebRequestEventRouter::OnBeforeRedirect(
void ExtensionWebRequestEventRouter::OnResponseStarted(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request,
int net_error) {
DCHECK_NE(net::ERR_IO_PENDING, net_error);
+ ExtensionNavigationUIData* navigation_ui_data =
+ ExtensionsBrowserClient::Get()->GetExtensionNavigationUIData(request);
if (ShouldHideEvent(browser_context, extension_info_map, request,
navigation_ui_data)) {
return;
@@ -895,18 +902,18 @@ void ExtensionWebRequestEventRouter::OnResponseStarted(
void ExtensionWebRequestEventRouter::OnResponseStarted(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request) {
- OnResponseStarted(browser_context, extension_info_map, navigation_ui_data,
- request, request->status().error());
+ OnResponseStarted(browser_context, extension_info_map, request,
+ request->status().error());
}
void ExtensionWebRequestEventRouter::OnCompleted(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request,
int net_error) {
+ ExtensionNavigationUIData* navigation_ui_data =
+ ExtensionsBrowserClient::Get()->GetExtensionNavigationUIData(request);
// We hide events from the system context as well as sensitive requests.
// However, if the request first became sensitive after redirecting we have
// already signaled it and thus we have to signal the end of it. This is
@@ -948,19 +955,19 @@ void ExtensionWebRequestEventRouter::OnCompleted(
void ExtensionWebRequestEventRouter::OnCompleted(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request) {
- OnCompleted(browser_context, extension_info_map, navigation_ui_data, request,
+ OnCompleted(browser_context, extension_info_map, request,
request->status().error());
}
void ExtensionWebRequestEventRouter::OnErrorOccurred(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request,
bool started,
int net_error) {
+ ExtensionNavigationUIData* navigation_ui_data =
+ ExtensionsBrowserClient::Get()->GetExtensionNavigationUIData(request);
// We hide events from the system context as well as sensitive requests.
// However, if the request first became sensitive after redirecting we have
// already signaled it and thus we have to signal the end of it. This is
@@ -1004,11 +1011,10 @@ void ExtensionWebRequestEventRouter::OnErrorOccurred(
void ExtensionWebRequestEventRouter::OnErrorOccurred(
void* browser_context,
const InfoMap* extension_info_map,
- ExtensionNavigationUIData* navigation_ui_data,
net::URLRequest* request,
bool started) {
- OnErrorOccurred(browser_context, extension_info_map, navigation_ui_data,
- request, started, request->status().error());
+ OnErrorOccurred(browser_context, extension_info_map, request, started,
+ request->status().error());
}
void ExtensionWebRequestEventRouter::OnURLRequestDestroyed(
« no previous file with comments | « extensions/browser/api/web_request/web_request_api.h ('k') | extensions/browser/extensions_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698