DevTools: Make Timeline navigation keyboard layout agnostic (WASD/ZQSD)

DevTools: Make Timeline navigation keyboard layout agnostic (WASD/ZQSD)

On QWERTY keyboards you can use the WASD keys to pan and zoom
the timeline flamechart.
On other keyboard layouts those keys aren't placed very intuitive.

Keyboard.code should be the appropriate way to program game-alike
controles because it represent the physical location of the key opposed
to the character generated by the pressed key: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

BUG=644227
Committed: https://crrev.com/52b4d80a29a24607e74ed1a9f3466208f98ebf62
Cr-Commit-Position: refs/heads/master@{#426349}

[JeroenVdb, 2016-10-18 19:11:12]

Description was changed from

==========
DevTools: Make Timeline navigation keyboard layout agnostic (WASD/ZQSD)

On QWERTY keyboards you can use the WASD keys to pan and zoom
the timeline flamechart.
On other keyboard layouts those keys aren't placed very intuitive.

Keyboard.code should be the appropriate way to program game-alike
controles because it represent the physical location of the key opposed
to the character generated by the pressed key:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

BUG=644227
==========

to

==========
DevTools: Make Timeline navigation keyboard layout agnostic (WASD/ZQSD)

On QWERTY keyboards you can use the WASD keys to pan and zoom
the timeline flamechart.
On other keyboard layouts those keys aren't placed very intuitive.

Keyboard.code should be the appropriate way to program game-alike
controles because it represent the physical location of the key opposed
to the character generated by the pressed key:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

BUG=644227
==========

[JeroenVdb, 2016-10-18 19:11:12]

vandenberghe.jeroen@gmail.com changed reviewers:
+ chenwilliam@chromium.com, pfeldman@chromium.com

[JeroenVdb, 2016-10-18 19:12:16]

vandenberghe.jeroen@gmail.com changed reviewers:
+ apavlov@chromium.org

[JeroenVdb, 2016-10-18 19:16:47]

vandenberghe.jeroen@gmail.com changed reviewers:
+ chenwilliam@chromium.org, pfeldman@chromium.org
- apavlov@chromium.org, chenwilliam@chromium.com, pfeldman@chromium.com

[JeroenVdb, 2016-10-18 19:27:13]

PTAL: Fix for DevTools issue #644227. This is a small commit which will be a
great help for non-QWERTY users using the Timeline.

[JeroenVdb, 2016-10-18 21:15:04]

The CQ bit was checked by vandenberghe.jeroen@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 21:16:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 21:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:16:06]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[chenwilliam, 2016-10-18 21:32:01]

chenwilliam@chromium.org changed reviewers:
+ alph@chromium.org

[chenwilliam, 2016-10-18 21:32:01]

alph@ - adding you as a reviewer since it looks like you just worked on this
file.

[alph, 2016-10-19 22:41:47]

Thank you for the patch. lgtm

[alph, 2016-10-19 22:42:05]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:42:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 00:20:09]

Description was changed from

==========
DevTools: Make Timeline navigation keyboard layout agnostic (WASD/ZQSD)

On QWERTY keyboards you can use the WASD keys to pan and zoom
the timeline flamechart.
On other keyboard layouts those keys aren't placed very intuitive.

Keyboard.code should be the appropriate way to program game-alike
controles because it represent the physical location of the key opposed
to the character generated by the pressed key:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

BUG=644227
==========

to

==========
DevTools: Make Timeline navigation keyboard layout agnostic (WASD/ZQSD)

On QWERTY keyboards you can use the WASD keys to pan and zoom
the timeline flamechart.
On other keyboard layouts those keys aren't placed very intuitive.

Keyboard.code should be the appropriate way to program game-alike
controles because it represent the physical location of the key opposed
to the character generated by the pressed key:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

BUG=644227
==========

[commit-bot: I haz the power, 2016-10-20 00:20:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:13:44]

Description was changed from

==========
DevTools: Make Timeline navigation keyboard layout agnostic (WASD/ZQSD)

On QWERTY keyboards you can use the WASD keys to pan and zoom
the timeline flamechart.
On other keyboard layouts those keys aren't placed very intuitive.

Keyboard.code should be the appropriate way to program game-alike
controles because it represent the physical location of the key opposed
to the character generated by the pressed key:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

BUG=644227
==========

to

==========
DevTools: Make Timeline navigation keyboard layout agnostic (WASD/ZQSD)

On QWERTY keyboards you can use the WASD keys to pan and zoom
the timeline flamechart.
On other keyboard layouts those keys aren't placed very intuitive.

Keyboard.code should be the appropriate way to program game-alike
controles because it represent the physical location of the key opposed
to the character generated by the pressed key:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

BUG=644227

Committed: https://crrev.com/52b4d80a29a24607e74ed1a9f3466208f98ebf62
Cr-Commit-Position: refs/heads/master@{#426349}
==========

[commit-bot: I haz the power, 2016-10-21 13:13:45]

Patchset 1 (id:??) landed as
https://crrev.com/52b4d80a29a24607e74ed1a9f3466208f98ebf62
Cr-Commit-Position: refs/heads/master@{#426349}