Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js

Issue 2431773002: DevTools: Make Timeline navigation keyboard layout agnostic (WASD/ZQSD) (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js
index d081828792f3b58a7beab12d4d842c17a8bd90b1..2d8ad8a6d591daaf261b96889c47b36d33e1f31b 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js
@@ -343,16 +343,16 @@ WebInspector.ChartViewport.prototype = {
return;
var zoomMultiplier = e.shiftKey ? 0.8 : 0.3;
var panMultiplier = e.shiftKey ? 320 : 80;
- if (e.keyCode === "A".charCodeAt(0)) {
+ if (e.code === "KeyA") {
this._handlePanGesture(-panMultiplier * this._pixelToTime);
e.consume(true);
- } else if (e.keyCode === "D".charCodeAt(0)) {
+ } else if (e.code === "KeyD") {
this._handlePanGesture(panMultiplier * this._pixelToTime);
e.consume(true);
- } else if (e.keyCode === "W".charCodeAt(0)) {
+ } else if (e.code === "KeyW") {
this._handleZoomGesture(-zoomMultiplier);
e.consume(true);
- } else if (e.keyCode === "S".charCodeAt(0)) {
+ } else if (e.code === "KeyS") {
this._handleZoomGesture(zoomMultiplier);
e.consume(true);
}
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698