Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2431483003: [DevTools] Split device discovery off DevToolsAnrdoidBridge. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Split device discovery off DevToolsAnrdoidBridge. This will be reused by ChromeDevToolsManagerDelegate. BUG=648775 Committed: https://crrev.com/d3e20708992845f6028098b2530dfd1bd3d4c7cc Cr-Commit-Position: refs/heads/master@{#426186}

Patch Set 1 #

Patch Set 2 : the bug with invalid weak pointer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -1233 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.h View 6 chunks +12 lines, -104 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 9 chunks +7 lines, -578 lines 0 comments Download
A chrome/browser/devtools/device/devtools_device_discovery.h View 1 1 chunk +147 lines, -0 lines 0 comments Download
A + chrome/browser/devtools/device/devtools_device_discovery.cc View 1 15 chunks +221 lines, -547 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
dgozman
Could you please take a look?
4 years, 2 months ago (2016-10-18 21:48:07 UTC) #2
pfeldman
lgtm
4 years, 2 months ago (2016-10-18 22:40:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431483003/20001
4 years, 2 months ago (2016-10-19 14:48:31 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 14:53:40 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:08:16 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3e20708992845f6028098b2530dfd1bd3d4c7cc
Cr-Commit-Position: refs/heads/master@{#426186}

Powered by Google App Engine
This is Rietveld 408576698