Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

Issue 2431483003: [DevTools] Split device discovery off DevToolsAnrdoidBridge. (Closed)
Patch Set: the bug with invalid weak pointer Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/chrome_devtools_manager_delegate.cc
diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
index ffd56872f827671df575f9ee4ebb100d7c41905f..8cb8f874b7dc6c70c89a92a0655a501e9e6c9b19 100644
--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
+++ b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
@@ -53,7 +53,7 @@ void ChromeDevToolsManagerDelegate::Inspect(
void ChromeDevToolsManagerDelegate::DevicesAvailable(
const DevToolsAgentHost::DiscoveryCallback& callback,
- const DevToolsAndroidBridge::CompleteDevices& devices) {
+ const DevToolsDeviceDiscovery::CompleteDevices& devices) {
DevToolsAgentHost::List result = DevToolsAgentHost::GetOrCreateAll();
for (const auto& complete : devices) {
for (const auto& browser : complete.second->browsers()) {
@@ -76,7 +76,7 @@ bool ChromeDevToolsManagerDelegate::DiscoverTargets(
providers.push_back(new TCPDeviceProvider(tcp_locations_));
device_manager_->SetDeviceProviders(providers);
- DevToolsAndroidBridge::QueryCompleteDevices(
+ DevToolsDeviceDiscovery::DiscoverOnce(
device_manager_.get(),
base::Bind(&ChromeDevToolsManagerDelegate::DevicesAvailable,
base::Unretained(this),
« no previous file with comments | « chrome/browser/devtools/chrome_devtools_manager_delegate.h ('k') | chrome/browser/devtools/device/devtools_android_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698