Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2399)

Unified Diff: net/spdy/spdy_header_block_test.cc

Issue 2431413004: Removes SpdyHeaderBlock::GetHeader(). No functional change. Not protected. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_header_block.cc ('k') | net/tools/quic/quic_simple_server_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_header_block_test.cc
diff --git a/net/spdy/spdy_header_block_test.cc b/net/spdy/spdy_header_block_test.cc
index 953fdfc812ba7fa6ceec9a1fa95d479dd49ed7b6..5f4429dbe35aad525c78274de1b8e0cfb8570ee1 100644
--- a/net/spdy/spdy_header_block_test.cc
+++ b/net/spdy/spdy_header_block_test.cc
@@ -38,7 +38,6 @@ TEST(SpdyHeaderBlockTest, EmptyBlock) {
EXPECT_TRUE(block.empty());
EXPECT_EQ(0u, block.size());
EXPECT_EQ(block.end(), block.find("foo"));
- EXPECT_EQ("", block.GetHeader("foo"));
EXPECT_TRUE(block.end() == block.begin());
// Should have no effect.
@@ -69,8 +68,8 @@ TEST(SpdyHeaderBlockTest, KeyMemoryReclaimedOnLookup) {
// Nothing should blow up when proxy1 is destructed, and we should be able to
// modify and access the SpdyHeaderBlock.
block["key"] = "value";
- EXPECT_EQ(base::StringPiece("value"), block["key"]);
- EXPECT_EQ(base::StringPiece("some value"), block["some other key name"]);
+ EXPECT_EQ("value", block["key"]);
+ EXPECT_EQ("some value", block["some other key name"]);
EXPECT_TRUE(block.find("some key name") == block.end());
}
@@ -85,15 +84,13 @@ TEST(SpdyHeaderBlockTest, AddHeaders) {
EXPECT_EQ(Pair("foo", string(300, 'x')), *block.find("foo"));
EXPECT_EQ("baz", block["bar"]);
- EXPECT_EQ("baz", block.GetHeader("bar"));
string qux("qux");
EXPECT_EQ("qux2", block[qux]);
- EXPECT_EQ("qux2", block.GetHeader(qux));
+ ASSERT_NE(block.end(), block.find("key"));
EXPECT_EQ(Pair("key", "value"), *block.find("key"));
block.erase("key");
EXPECT_EQ(block.end(), block.find("key"));
- EXPECT_EQ("", block.GetHeader("key"));
}
// This test verifies that SpdyHeaderBlock can be copied using Clone().
« no previous file with comments | « net/spdy/spdy_header_block.cc ('k') | net/tools/quic/quic_simple_server_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698