Removes SpdyHeaderBlock::GetHeader(). No functional change. Not protected.

net/spdy/spdy_header_block_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_header_block.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/values.h"
@@ skipping 20 matching lines @@
                                                      base::StringPiece v) {
   return make_pair(k, v);
 }
 
 // This test verifies that SpdyHeaderBlock behaves correctly when empty.
 TEST(SpdyHeaderBlockTest, EmptyBlock) {
   SpdyHeaderBlock block;
   EXPECT_TRUE(block.empty());
   EXPECT_EQ(0u, block.size());
   EXPECT_EQ(block.end(), block.find("foo"));
-  EXPECT_EQ("", block.GetHeader("foo"));
   EXPECT_TRUE(block.end() == block.begin());
 
   // Should have no effect.
   block.erase("bar");
 }
 
 TEST(SpdyHeaderBlockTest, KeyMemoryReclaimedOnLookup) {
   SpdyHeaderBlock block;
   base::StringPiece copied_key1;
   {
@@ skipping 10 matching lines @@
   // Therefore, we expect the pointers of the two StringPieces to be equal.
   EXPECT_EQ(copied_key1.data(), copied_key2.data());
 
   {
     auto proxy1 = block["some key name"];
     block["some other key name"] = "some value";
   }
   // Nothing should blow up when proxy1 is destructed, and we should be able to
   // modify and access the SpdyHeaderBlock.
   block["key"] = "value";
-  EXPECT_EQ(base::StringPiece("value"), block["key"]);
-  EXPECT_EQ(base::StringPiece("some value"), block["some other key name"]);
+  EXPECT_EQ("value", block["key"]);
+  EXPECT_EQ("some value", block["some other key name"]);
   EXPECT_TRUE(block.find("some key name") == block.end());
 }
 
 // This test verifies that headers can be set in a variety of ways.
 TEST(SpdyHeaderBlockTest, AddHeaders) {
   SpdyHeaderBlock block;
   block["foo"] = string(300, 'x');
   block["bar"] = "baz";
   block["qux"] = "qux1";
   block["qux"] = "qux2";
   block.insert(std::make_pair("key", "value"));
 
   EXPECT_EQ(Pair("foo", string(300, 'x')), *block.find("foo"));
   EXPECT_EQ("baz", block["bar"]);
-  EXPECT_EQ("baz", block.GetHeader("bar"));
   string qux("qux");
   EXPECT_EQ("qux2", block[qux]);
-  EXPECT_EQ("qux2", block.GetHeader(qux));
+  ASSERT_NE(block.end(), block.find("key"));
   EXPECT_EQ(Pair("key", "value"), *block.find("key"));
 
   block.erase("key");
   EXPECT_EQ(block.end(), block.find("key"));
-  EXPECT_EQ("", block.GetHeader("key"));
 }
 
 // This test verifies that SpdyHeaderBlock can be copied using Clone().
 TEST(SpdyHeaderBlockTest, CopyBlocks) {
   SpdyHeaderBlock block1;
   block1["foo"] = string(300, 'x');
   block1["bar"] = "baz";
   block1.insert(make_pair("qux", "qux1"));
 
   SpdyHeaderBlock block2 = block1.Clone();
@@ skipping 86 matching lines @@
 
   EXPECT_EQ("key1=value1; key2=value2; key3=value3", block["cookie"]);
   EXPECT_EQ("baz", block["foo"]);
   EXPECT_EQ(string("h1v1\0h1v2\0h1v3", 14), block["h1"]);
   EXPECT_EQ(string("h2v1\0h2v2\0h2v3", 14), block["h2"]);
   EXPECT_EQ(string("h3v2\0h3v3", 9), block["h3"]);
 }
 
 }  // namespace test
 }  // namespace net