Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2431413004: Removes SpdyHeaderBlock::GetHeader(). No functional change. Not protected. (Closed)

Created:
4 years, 2 months ago by yasong
Modified:
4 years, 2 months ago
Reviewers:
Bence, yasong1
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes SpdyHeaderBlock::GetHeader(). No functional change. Not protected. Equivalent functionality is provided by SpdyHeaderBlock::find(). This CL lands server change 135849112 by birenroy. BUG=488484 Committed: https://crrev.com/ebe52a7f5951dd6cb91b913592307601e1e3cf3b Cr-Commit-Position: refs/heads/master@{#426786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M net/spdy/spdy_header_block.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/spdy/spdy_header_block.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M net/spdy/spdy_header_block_test.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yasong
On 2016/10/20 21:05:24, yasong wrote: > mailto:yasong@chromium.org changed reviewers: > + mailto:bnc@chromium.org Ready for review. ...
4 years, 2 months ago (2016-10-20 21:05:47 UTC) #7
Bence
On 2016/10/20 21:05:47, yasong wrote: > On 2016/10/20 21:05:24, yasong wrote: > > mailto:yasong@chromium.org changed ...
4 years, 2 months ago (2016-10-21 00:28:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431413004/1
4 years, 2 months ago (2016-10-21 13:42:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 13:55:48 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 14:00:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebe52a7f5951dd6cb91b913592307601e1e3cf3b
Cr-Commit-Position: refs/heads/master@{#426786}

Powered by Google App Engine
This is Rietveld 408576698