Issue 2431383003: Don't let roll scripts use short hashes

Issue 2431383003: Don't let roll scripts use short hashes (Closed)

Created:
4 years, 2 months ago by agable

Modified:
4 years, 2 months ago

Reviewers:
Dirk Pranke, scottmg, Kai Ninomiya, Ken Russell (switch to Gerrit)

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Don't let roll scripts use short hashes R=kainino@chromium.org BUG=657642 Committed: https://crrev.com/2e9de0e8e7df6eedba8de5d2e29210b26d641266 Cr-Commit-Position: refs/heads/master@{#426359}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	tools/roll_angle.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/roll_webgl_conformance.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/roll_webrtc.py	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 13 (6 generated)

Ken Russell (switch to Gerrit)

CC'ing OWNERS in tools/ directory. Thanks, this looks good to me but I'm not an ...

4 years, 2 months ago (2016-10-19 23:41:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431383003/1

4 years, 2 months ago (2016-10-20 00:12:36 UTC) #9

commit-bot: I haz the power

4 years, 2 months ago (2016-10-21 13:14:04 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2e9de0e8e7df6eedba8de5d2e29210b26d641266
Cr-Commit-Position: refs/heads/master@{#426359}