tools/roll_webrtc.py - Issue 2431383003: Don't let roll scripts use short hashes - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(41)

My Issues | Starred Open | Closed | All

Unified Diff: tools/roll_webrtc.py

Issue 2431383003: Don't let roll scripts use short hashes (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « tools/roll_webgl_conformance.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/roll_webrtc.py

diff --git a/tools/roll_webrtc.py b/tools/roll_webrtc.py

index 24885652d9b9a3f9715235af659dc7aeac044a4c..fc72ff913a4d49952c874d5d9df990b3b19409ad 100755

--- a/tools/roll_webrtc.py

+++ b/tools/roll_webrtc.py

@@ -220,7 +220,8 @@ class AutoRoller(object):

self._RunCommand(['git', 'fetch', 'origin'], working_dir=working_dir)

revision_range = git_hash or 'origin'

ret = self._RunCommand(

- ['git', '--no-pager', 'log', revision_range, '--pretty=full', '-1'],

+ ['git', '--no-pager', 'log', revision_range,

+ '--no-abbrev-commit', '--pretty=full', '-1'],

working_dir=working_dir)

return CommitInfo(_ParseGitCommitPosition(ret), _ParseGitCommitHash(ret),

git_repo_url)

« no previous file with comments | « tools/roll_webgl_conformance.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698