Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2431373003: [NTP Client][M55] Make status cards non dismissable (Closed)

Created:
4 years, 2 months ago by dgn
Modified:
4 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[NTP Client][M55] Make status cards non dismissable NOPRESUBMIT=true NOTRY=true BUG=657494

Patch Set 1 #

Patch Set 2 : also block on action item #

Patch Set 3 : make the signin promo dismissable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
dgn
PTAL
4 years, 2 months ago (2016-10-19 15:43:01 UTC) #2
Bernhard Bauer
LGTM, A++++, would merge again.
4 years, 2 months ago (2016-10-19 15:52:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431373003/40001
4 years, 1 month ago (2016-10-24 10:25:00 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 10:28:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698